feat(Android): hide maps #621
Open
+279
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
force-pushed
the
mth-android-hide-maps
branch
from
a1c8fb7 to
a2b667c
Compare
EmmaSimon
reviewed
Jan 7, 2025
| } | ||
| ) | ||
| LaunchedEffect(nearbyTransit.hideMaps) { | ||
| if (nearbyTransit.hideMaps) { |
There was a problem hiding this comment.
Shouldn't this be !nearbyTransit.hideMaps?
There was a problem hiding this comment.
I don't think so - if we show maps, the map will be the connection between the LocationDataManager and the ViewportProvider, but if we hide maps, we need to manually wire those together, like we do on iOS.
EmmaSimon
approved these changes
Jan 7, 2025
| } | ||
| ) | ||
| LaunchedEffect(nearbyTransit.hideMaps) { | ||
| if (nearbyTransit.hideMaps) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Map | Hide maps functionality
Stacked on #618 since the acceptance criteria specify that the location services button is in-scope for this ticket.
iOS
android
withContext(Dispatchers.Default)where possibleTesting
Manually validated that everything looks correct with hide maps turned on, except for the stop details page, which looks wrong and needs to be fixed before this PR is actually ready for review. Added a unit test to check that maps are correctly hidden and shown.