Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SCU installation scripts #81

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix SCU installation scripts #81

merged 1 commit into from
Oct 3, 2024

Conversation

panentheos
Copy link
Contributor

@panentheos panentheos commented Sep 27, 2024

Fixes a few issues that came up during testing of the SCU install process.

  • Makes the ISO build script fail loudly on errors
  • Allows specifying git branches with slashes
  • Adds users to the admin group for sudo privileges
  • Uses the classic flag to install the SSM agent
  • Installs the SSH server on SCUs

@panentheos panentheos requested a review from a team as a code owner September 27, 2024 18:43
Copy link
Contributor

@Warren-Johnson-TID Warren-Johnson-TID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panentheos Ian added a comment about the sudo vs admin group. Can you check it out?

@Warren-Johnson-TID Warren-Johnson-TID self-requested a review October 3, 2024 13:48
Copy link
Contributor

@Warren-Johnson-TID Warren-Johnson-TID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Warren-Johnson-TID Warren-Johnson-TID merged commit 9d14469 into main Oct 3, 2024
8 checks passed
@Warren-Johnson-TID Warren-Johnson-TID deleted the bhw/scu-fix branch October 3, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants