Add currently supported Node.js versions to CI #758
Closed
+1,004
−3,609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not breaking change because `engine-strict` is not set in .npmrc and npm only warns if the user uses legacy Node.js versions.
|
...Is Travis CI working? If you are considering migration to GitHub Actions which is easier to use for free, I can contribute to activating GHA. |
|
I opened #759 to replace Travis CI with GitHub Actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since EJS is currently tested on legacy Node.js v8-12, I added currently supported v18-22 (except for non-LTS versions) on the CI.
I left Node.js v8-12 to avoid breaking changes, but in my opinion, they should be removed on the next major update.