Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scale factor to generate_vsp_surfaces #419

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

timryanb
Copy link
Contributor

@timryanb timryanb commented Dec 21, 2023

Purpose

Adding argument to scale incoming vsp models. Useful for when geometry model has differing units from analysis model

Expected time until merged

A week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@timryanb timryanb requested a review from a team as a code owner December 21, 2023 16:07
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ebabd1) 94.50% compared to head (a48d40d) 93.84%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   94.50%   93.84%   -0.66%     
==========================================
  Files         103      104       +1     
  Lines        6445     6470      +25     
==========================================
- Hits         6091     6072      -19     
- Misses        354      398      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kanekosh kanekosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Tim. The docs build failed because of the system_packages: true line in readthedocs.yaml. This was already fixed in PR #417 so it should work fine when merged to main.

@kanekosh kanekosh merged commit ebc6fe6 into mdolab:main Dec 21, 2023
8 of 9 checks passed
@timryanb timryanb deleted the adding-vsp-scale branch December 21, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants