Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot_wingbox.py to work for matplotlib v3.8+ #424

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

shamsheersc19
Copy link
Contributor

Purpose

Fix plot_wingbox.py to work for matplotlib v3.8+.
The dist attribute for 3-D plots has been deprecated in recent matplotlib versions.
See Issue #423

Expected time until merged

1 day
Code review should only take a few minutes.

Type of change

Bugfix (non-breaking change which fixes an issue)

Testing

Run the wingbox example in the examples dir (can reduce "num_y" to 15 and "num_x" to 3 to decrease run time) and call the plot_wingbox script (usage: python ../utils/plot_wingbox.py aerostruct.db).
Tested with matplotlib versions:

  • 3.6.0
  • 3.7.0
  • 3.8.0
  • 3.8.3

image

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • [ x] I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@shamsheersc19 shamsheersc19 requested a review from a team as a code owner March 5, 2024 19:34
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (def4df0) to head (4f225cf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   94.51%   92.56%   -1.95%     
==========================================
  Files         104      104              
  Lines        6470     6470              
==========================================
- Hits         6115     5989     -126     
- Misses        355      481     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kanekosh kanekosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Sham!

@kanekosh kanekosh merged commit a8a272a into mdolab:main Mar 6, 2024
9 checks passed
@eytanadler
Copy link
Collaborator

@shamsheersc19 if you are willing, could you also make this fix in the plot_wing.py file? I think it has the same problem.

@shamsheersc19
Copy link
Contributor Author

@shamsheersc19 if you are willing, could you also make this fix in the plot_wing.py file? I think it has the same problem.

@eytanadler thanks for pointed that out. I just created a new PR for it.

Thanks for the quick turnaround @kanekosh and @eytanadler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants