-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fix to mesh generator #430
Conversation
Codecov is failing, but it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the code both simpler and more general, very nice! (Nevermind about bumping the patch, I got it)
If you don't mind, I have a couple things to try with GHA to try to get codecov working that I'll add here. No guarantees that it'll work though.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 93.92% 93.94% +0.02%
==========================================
Files 104 104
Lines 6472 6461 -11
==========================================
- Hits 6079 6070 -9
+ Misses 393 391 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes make sense. The inconsistent chordwise positioning of the wing added extra complexity when doing stability analysis. These changes will break my 740 code as result but they are for the better.
@sabakhshi I'm planning on adding a stability-constrained example to the docs, so I'll document the origin of the chordwise coordinate at that time. |
Purpose
OAS mesh generator currently only accepts the chordwise discretization
nx
to be 2 or an odd number because of how it generates the cosine spacing in the chordwise direction. This PR fixes the mesh generator to make it work with even numbers fornx
.I also realized a weird behavior for rectangle wings: the default chordwise coordinate for [LE, TE] was
[0, chord]
whennx=2
and[-chord/2, chord/2]
whennx >= 3
. Now I fixed it, and the default coordinate is[0, chord]
for anynx
. I adjusted a few test cases accordingly because it affects CM computation.Also made a minor edit to the GHA setting so that the "latest" build continues even if the "oldest" job fails, and vice versa.
Closes #378
Mesh examples
Expected time until merged
Week
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable