Add iframe support #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvxd
force-pushed
the
iframes
branch
3 times, most recently
from
298e1e7 to
450d740
Compare
chrisvxd
force-pushed
the
iframes
branch
2 times, most recently
from
070c75c to
dd08e4a
Compare
chrisvxd
force-pushed
the
iframes
branch
5 times, most recently
from
7ed6934 to
fa74b00
Compare
…hn cloning Legacy from when iframe support required renderClone.
This allows the user to explicitly disable displacement animations. For example, complex list objects can cause iOS GPU memory crashes in Safari when combined with iframes and CSS transforms, but disabling displacement animations fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iframe support in a limited way that works for Puck:
Adds:
shouldRenderOriginalAPI for use withrenderCloneAPI (from an earlier legacy implementation, but still useful)Does not add support for the following, as not required by Puck:
renderCloneAPI, which is required to enable items to retain viability when dragging between iframesConsiderations
use-style-marshal. However, this was removed in favour of the user-land style syncing, such as via auto-frame-component.renderClonedoesn't work with iframes, which might be due to the implementation. Could explore playing around with theviewportstate instead, but it wasn't necessary for our immediate requirements.