Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing TaskInfoStatus and TaskInfoType handling in ObjectExtensions #557

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

postmeback
Copy link
Contributor

Pull Request

Related issue

Fixes #509

What does this PR do?

  • Adds 4 lines of code to include TaskInfoStatus and TaskInfoType in the respective function.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

image

Tests and formatted ran successfully

@postmeback postmeback marked this pull request as draft August 3, 2024 12:06
@postmeback postmeback marked this pull request as ready for review August 5, 2024 17:12
@postmeback
Copy link
Contributor Author

Requesting the reviewers to have a look.

@curquiza curquiza requested a review from ahmednfwela August 6, 2024 08:07
@ahmednfwela
Copy link
Collaborator

Thanks for your contribution

bors merge

Copy link
Contributor

meili-bors bot commented Aug 6, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit c4acbe8 into meilisearch:main Aug 6, 2024
4 checks passed
@curquiza curquiza added the bug Something isn't working label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaskInfoStatus and TaskInfoType Types not accounted for in GetTasksAsync
3 participants