-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version for the next release (v0.16.0) #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
440: Update version for the next release (v0.16.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-swift to a new version: "v0.16.0" Co-authored-by: meili-bot <[email protected]>
Build failed: |
bors merge |
440: Update version for the next release (v0.16.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-swift to a new version: "v0.16.0" Co-authored-by: meili-bot <[email protected]>
Build failed: |
All failures appear random. bors try |
tryBuild failed: |
Need to take a look at that "Install MeiliSearch" step, it's constantly causing problems in the automation. Is it similar to other language packages? |
It is not. The other languages uses Docker. But Docker only works on Linux in GitHub Actions. |
yeah this problem is really random, we never figured out why it happens... sometimes it's impossible to merge for multiple hours, and after it's ok bors merge |
440: Update version for the next release (v0.16.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-swift to a new version: "v0.16.0" Co-authored-by: meili-bot <[email protected]>
Build failed: |
Looks like it's impossible now... but we merged this PR last week... |
Not suggesting that upgrade hasn't broken something else, but looks extremely unlikely to have made this issue with resolving the MS dependency any worse. It's always been problematic as far as I can see, just now even more so... Maybe hitting some weird rate limits? |
This was our first thought. That's why we use this env variable to increase the rate:
|
I would guess that it isn't a GitHub Actions rate limit issue because the install script downloads successfully, though I could be wrong. The install script uses the GitHub API so possible a rate limit there? Because the install script shows the same message for multiple failure types (which makes sence for it's main purpose) it isn't possible to tell why it fails. My suggestion would be to either use a custom version of the bash script here that includes more logging, or to update the main script with an option to pass a |
bors merge |
440: Update version for the next release (v0.16.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-swift to a new version: "v0.16.0" Co-authored-by: meili-bot <[email protected]>
Build failed: |
(I tried 😅 ) @sanders41 we already made investigation with bidoubiwa a long time ago: we don't know why but sometime GitHub does not return the release when calling "https://api.github.com/repos/meilisearch/meilisearch/releases/latest" It was a long time ago so maybe the problem is not the same anymore |
Hello everyone, I merge this PR manually since tests worked with previous PR I discussed with @brunoocasali and I will investigate this to fix the problem in the coming weeks. Not my priority but it's in my TODO 😊 |
This PR is auto-generated.
The automated script updates the version of meilisearch-swift to a new version: "v0.16.0"