Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Settings write-back #2346

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Mar 27, 2024

Why signals?

A config update may b e triggered in a number of moments during a sync (error handling, authentication, etc.). Blinker's signals would let us decouple emitting a signal at one of those moments, from processing the event in some other place.


📚 Documentation preview 📚: https://meltano-sdk--2346.org.readthedocs.build/en/2346/

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (9d0c08b) to head (f098bcf).
Report is 80 commits behind head on main.

Files Patch % Lines
singer_sdk/plugin_base.py 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
+ Coverage   89.18%   89.23%   +0.05%     
==========================================
  Files          54       54              
  Lines        4788     4794       +6     
  Branches      936      936              
==========================================
+ Hits         4270     4278       +8     
+ Misses        361      359       -2     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Mar 27, 2024

CodSpeed Performance Report

Merging #2346 will not alter performance

Comparing edgarrmondragon/feat/write-back (f098bcf) with main (9d0c08b)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/write-back branch from fb1bf74 to a0aa85c Compare March 27, 2024 14:45
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/write-back branch from a0aa85c to 988da0a Compare April 4, 2024 20:44
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/write-back branch from 988da0a to 2daf3f5 Compare May 7, 2024 23:38
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/write-back branch from 2daf3f5 to f098bcf Compare May 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant