Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Interruption and termination signals are handled in taps and targets #2620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 22, 2024

Closes #129


📚 Documentation preview 📚: https://meltano-sdk--2620.org.readthedocs.build/en/2620/

Copy link

codspeed-hq bot commented Aug 22, 2024

CodSpeed Performance Report

Merging #2620 will not alter performance

Comparing edgarrmondragon/feat/signals (aa5831a) with main (344a218)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (344a218) to head (aa5831a).
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2620   +/-   ##
=======================================
  Coverage   90.81%   90.82%           
=======================================
  Files          62       62           
  Lines        5130     5133    +3     
  Branches      660      660           
=======================================
+ Hits         4659     4662    +3     
  Misses        330      330           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/signals branch 2 times, most recently from 57ed344 to b795525 Compare August 22, 2024 02:45
@edgarrmondragon edgarrmondragon changed the title feat: Interruption and termination signals in taps and targets feat: Interruption and termination signals are handled in taps and targets Aug 22, 2024
@edgarrmondragon edgarrmondragon self-assigned this Aug 22, 2024
@edgarrmondragon edgarrmondragon added kind/Feature New feature or request Release Highlight Call this out in the release notes labels Aug 22, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/signals branch from ce5a41e to f87387e Compare August 28, 2024 16:13
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/signals branch from f87387e to af2c00e Compare November 15, 2024 23:14
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/signals branch from af2c00e to aa5831a Compare November 15, 2024 23:27
@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 15, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Feature New feature or request Release Highlight Call this out in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle SIGTERM messages to shut down gracefully
1 participant