Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(targets): Added a class method to instantiate JSONSchemaToSQL from the target configuration #2782

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 28, 2024

Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #2782 will not alter performance

Comparing edgarrmondragon/refactor/jsonschematosql-fromconfig (4301625) with main (363d4bc)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/jsonschematosql-fromconfig branch from bc026c7 to 934ef21 Compare November 28, 2024 23:23
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (363d4bc) to head (4301625).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2782   +/-   ##
=======================================
  Coverage   91.02%   91.03%           
=======================================
  Files          62       62           
  Lines        5169     5173    +4     
  Branches      666      666           
=======================================
+ Hits         4705     4709    +4     
  Misses        326      326           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon self-assigned this Nov 28, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/jsonschematosql-fromconfig branch 3 times, most recently from 55b3d2c to 4be6949 Compare November 28, 2024 23:48
@edgarrmondragon edgarrmondragon changed the title refactor: Added a class method to instantiate JSONSchemaToSQL from the tap configuration refactor(targets): Added a class method to instantiate JSONSchemaToSQL from the target configuration Nov 30, 2024
@edgarrmondragon edgarrmondragon added the Type/Target Singer targets label Nov 30, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/jsonschematosql-fromconfig branch from 4be6949 to de53f85 Compare November 30, 2024 04:04
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/jsonschematosql-fromconfig branch from de53f85 to 42a702d Compare November 30, 2024 20:27
tests/core/test_connector_sql.py Outdated Show resolved Hide resolved
tests/core/test_connector_sql.py Outdated Show resolved Hide resolved
edgarrmondragon

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Target Singer targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant