Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fail early if input files to --catalog or --state do not exist #2788

Merged

Conversation

Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #2788 will not alter performance

Comparing edgarrmondragon/refactor/fail-early-file-doesnt-exist (7e5df31) with main (363d4bc)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (363d4bc) to head (7e5df31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2788   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files          62       62           
  Lines        5169     5170    +1     
  Branches      666      666           
=======================================
+ Hits         4705     4706    +1     
  Misses        326      326           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 30, 2024 22:54
@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 30, 2024
@edgarrmondragon edgarrmondragon self-assigned this Nov 30, 2024
@edgarrmondragon edgarrmondragon merged commit a553c38 into main Nov 30, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/fail-early-file-doesnt-exist branch November 30, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Type/Tap Singer taps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant