Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: A warning is now emitted when no streams are selected #2791

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 2, 2024

@edgarrmondragon edgarrmondragon linked an issue Dec 2, 2024 that may be closed by this pull request
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #2791 will not alter performance

Comparing 2779-failwarn-when-there-are-no-selected-streams (d1d4287) with main (e2a78e9)

Summary

✅ 7 untouched benchmarks

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.33%. Comparing base (e2a78e9) to head (d1d4287).

Files with missing lines Patch % Lines
singer_sdk/tap_base.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2791      +/-   ##
==========================================
+ Coverage   91.27%   91.33%   +0.05%     
==========================================
  Files          62       62              
  Lines        5182     5192      +10     
  Branches      669      670       +1     
==========================================
+ Hits         4730     4742      +12     
+ Misses        319      317       -2     
  Partials      133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon added this to the v0.44 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail/warn when there are no selected streams
2 participants