Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-GCP PALM providers #579

Closed
wants to merge 7 commits into from

Conversation

Mark-Zeng
Copy link
Contributor

@Mark-Zeng Mark-Zeng commented Sep 7, 2023

Description

Add new LLM and embedding providers for PALM (non-GCP)

Fixes #480

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Since the new embedder and llm uses API, the test is done manually by adding data and sending queries.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

pyproject.toml Outdated Show resolved Hide resolved
embedchain/llm/palm_llm.py Outdated Show resolved Hide resolved
embedchain/embedder/palm.py Outdated Show resolved Hide resolved
embedchain/embedder/palm.py Outdated Show resolved Hide resolved
embedchain/llm/palm.py Outdated Show resolved Hide resolved
@deshraj
Copy link
Collaborator

deshraj commented Oct 6, 2023

Thanks @Mark-Zeng for the contribution. I reviewed the PR and it looks good in general apart from small bugs.

You can fix these bugs by cherry picking this commit in your PR: d2a3acd

Also, please rebase after cherry picking so that we can merge your PR. Thanks!

@Dev-Khant
Copy link
Member

@Mark-Zeng Can you please resolve the merge conflicts so we can merge the PR?

@deshraj
Copy link
Collaborator

deshraj commented Jun 24, 2024

Closing this PR because of inactivity.

@deshraj deshraj closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for Palm LLM Models/Embeddings
5 participants