-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-GCP PALM providers #579
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachho
reviewed
Sep 11, 2023
cachho
reviewed
Sep 11, 2023
cachho
reviewed
Sep 16, 2023
cachho
reviewed
Sep 16, 2023
cachho
reviewed
Sep 16, 2023
cachho
reviewed
Sep 16, 2023
Thanks @Mark-Zeng for the contribution. I reviewed the PR and it looks good in general apart from small bugs. You can fix these bugs by cherry picking this commit in your PR: d2a3acd Also, please rebase after cherry picking so that we can merge your PR. Thanks! |
@Mark-Zeng Can you please resolve the merge conflicts so we can merge the PR? |
Closing this PR because of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new LLM and embedding providers for PALM (non-GCP)
Fixes #480
Type of change
How Has This Been Tested?
Since the new embedder and llm uses API, the test is done manually by adding data and sending queries.
Checklist:
Maintainer Checklist