Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove load_and_embed_v1 method since it is not used #638

Merged
merged 6 commits into from Sep 26, 2023
Merged

Remove load_and_embed_v1 method since it is not used #638

merged 6 commits into from Sep 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2023

Description

Since load_and_embed_v2 is the method that is being used, load_and_embed (v1) has been removed from the embedchain class.

Fixes #629

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

Copy link
Collaborator

@deshraj deshraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Left a small comment to resolve.

@@ -246,93 +246,7 @@ def add_local(
)
return self.add(source=source, data_type=data_type, metadata=metadata, config=config)

def load_and_embed(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the load_and_embed function and also rename load_and_embed_v2 to load_and_embed function?

Copy link
Author

@ghost ghost Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deshraj The mentioned changes are made.

@taranjeet
Copy link
Member

@dev-ayush69 : can you please resolve the conflicts? and let me know when it done.

@ghost
Copy link
Author

ghost commented Sep 26, 2023

@dev-ayush69 : can you please resolve the conflicts? and let me know when it done.

@taranjeet I have resolved the conflicts.

@taranjeet
Copy link
Member

Thanks.
Can you please make sure that all the tests pass?
@dev-ayush69

@ghost
Copy link
Author

ghost commented Sep 26, 2023

@taranjeet Done 👍🏼

@taranjeet taranjeet merged commit b8a838a into mem0ai:main Sep 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove load_and_embed v1 method from embedchain class
2 participants