-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove load_and_embed_v1 method since it is not used #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Left a small comment to resolve.
@@ -246,93 +246,7 @@ def add_local( | |||
) | |||
return self.add(source=source, data_type=data_type, metadata=metadata, config=config) | |||
|
|||
def load_and_embed( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove the load_and_embed
function and also rename load_and_embed_v2
to load_and_embed
function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deshraj The mentioned changes are made.
@dev-ayush69 : can you please resolve the conflicts? and let me know when it done. |
@taranjeet I have resolved the conflicts. |
Thanks. |
@taranjeet Done 👍🏼 |
Description
Since
load_and_embed_v2
is the method that is being used,load_and_embed
(v1) has been removed from theembedchain
class.Fixes #629
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist
load_and_embed
v1 method fromembedchain
class #629