feat: added timeouts to requests to prevent blocking requests #890
+66
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Add Optional Timeout Parameters to HTTP Requests
Summary
This pull request introduces optional
timeout
parameters to all functions in theFirecrawlApp
class that make HTTP requests. This enhancement improves the robustness and resilience of the application by ensuring that calls do not hang indefinitely, which helps prevent resource starvation and supports better error handling.Key Changes
Added
timeout
as an optional argument to the following functions:scrape_url
crawl_url
async_crawl_url
check_crawl_status
Updated internal
_post_request
and_get_request
methods to use thetimeout
value when provided.Default behavior remains unchanged if
timeout
is not specified, ensuring backward compatibility.Benefits