Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to raw values in object attributes #136

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

AlObolenski
Copy link
Contributor

@AlObolenski AlObolenski commented Sep 3, 2024

WHAT

If fallback option is enabled, add parsed value to results even if there is an error (in objects)

WHY

At the moment, the fallback option doesn't work for object attributes

Copy link
Member

@ryan-ph ryan-ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@ryan-ph ryan-ph merged commit 8027023 into mercari:main Sep 4, 2024
3 checks passed
@AlObolenski AlObolenski deleted the raw_val_object_attr branch September 4, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants