Skip to content

Commit

Permalink
fix the message when no scaling down is made (#385)
Browse files Browse the repository at this point in the history
  • Loading branch information
sanposhiho authored Mar 15, 2024
1 parent c51c9cf commit 690e0f9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/recommender/recommender.go
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,9 @@ func (s *Service) calculateBestNewSize(
return jastified, fmt.Sprintf("change %v request (%v) (%v → %v) based on VPA suggestion", k, containerName, resourceRequest.MilliValue(), jastified), nil
}

return resourceRequest.MilliValue(), "The autoscaling policy for this resource is Off", nil
return resourceRequest.MilliValue(),
fmt.Sprintf("Tortoise recommends %v as a new %v request (%v), but it's very small scale down change, so tortoise just ignores it", idealSize, k, containerName),
nil
}

// p == v1beta3.AutoscalingTypeHorizontal
Expand Down

0 comments on commit 690e0f9

Please sign in to comment.