chore: shorten flow-huge.spec.js test case using .repeat

[Yokozuna59]

📑 Summary

Just use ''.repeat(20000); instead of hardcoding nodes.

When the file is opened in editors, it stops highlighting and becomes laggy.

Make sure you

• 📖 have read the contribution guidelines
• 🔖 targeted develop branch

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	ca960c4
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/650d6d02b1736a0008bdc4f2
😎 Deploy Preview	https://deploy-preview-4859--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Merging #4859 (ca960c4) into develop (0534d75) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4859   +/-   ##
========================================
  Coverage    79.67%   79.67%           
========================================
  Files          148      148           
  Lines        13025    13025           
  Branches       612      612           
========================================
  Hits         10378    10378           
  Misses        2510     2510           
  Partials       137      137           

Flag	Coverage Δ
e2e	84.71% <ø> (ø)
unit	43.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[aloisklink]

I believe this test fails after your changes, because the string is now shorter:

 FAIL  packages/mermaid/src/diagrams/flowchart/parser/flow-huge.spec.js > [Text] when parsing > it should handle huge files > it should handlehuge diagrams
AssertionError: expected 40000 to be 47917 // Object.is equality

- Expected
+ Received

- 47917
+ 40000

 ❯ packages/mermaid/src/diagrams/flowchart/parser/flow-huge.spec.js:24:28
     22| 
     23|       expect(edges[0].type).toBe('arrow_point');
     24|       expect(edges.length).toBe(47917);
       |                            ^
     25|       expect(Object.keys(vert).length).toBe(2);
     26|     });

See my comments on how to fix this.

Edit: I've also changed the label on this PR to Skip changelog, since it doesn't affect users, but we don't really have labeling rules, so feel free to change it if you disagree.

[aloisklink]

Awesome! The test works now :)

The next thing would be updating https://github.com/mermaid-js/mermaid/blob/735aceb37a3a5907c97e9de0ca243fa6ae1b31a4/cypress/platform/huge.html to do the same thing.

@Yokozuna59, since this PR is very small and low-risk, I'm happy for you to merge this PR now (I'll let you decide when to merge it since you've assigned yourself to this PR).

[Yokozuna59]

The next thing would be updating https://github.com/mermaid-js/mermaid/blob/735aceb37a3a5907c97e9de0ca243fa6ae1b31a4/cypress/platform/huge.html to do the same thing.

Sure, but the default maxTextSize is 50000, should I also update it? The current test size is 287502 :)
I don't think it would be able to render it with that size. Even the browser says so :) :

@Yokozuna59, since this PR is very small and low-risk, I'm happy for you to merge this PR now (I'll let you decide when to merge it since you've assigned yourself to this PR).

No worries.

[aloisklink]

The next thing would be updating https://github.com/mermaid-js/mermaid/blob/735aceb37a3a5907c97e9de0ca243fa6ae1b31a4/cypress/platform/huge.html to do the same thing.

Sure, but the default maxTextSize is 50000, should I also update it? The current test size is 287502 :) I don't think it would be able to render it with that size. Even the browser says so :) :

It looks like rendering a "Maximum text size in diagram exceeded" error message is the expected behavior, see #1221, so we shouldn't change maxTextSize.

[Yokozuna59]

@aloisklink I see, then is the PR ready to be merged?

[aloisklink]

@aloisklink I see, then is the PR ready to be merged?

Yep, everything looks great to me :) (it's even better now with the cypress/platform/huge.html changes).

I'll merge it myself, since this PR has been open for a few days already, but since it's only test changes, we don't really need reviews from anybody else.