Add a check that index being shuffled isnt at the beginning to avoid segmentation fault. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug can cause a segmentation fault. Add task ABC Add task DEF Set schedule of ABC to today. Set schedule of DEF to today. This should cause a segmentation fault as the access after the i-- should point to an illegal address in this case. Bug raised in issue meskio#10
Add check to avoid null pointer exception
|
Adding more info to give specific steps to generate Segmentation fault this pull request attempts to fix.
Version info TuDu 0.10.3 (2019) |
AlexTheAussieNerd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If adding a tasks ABC and DEF and then setting schedules for both to be the same day (e.g. both tasks due today or tomorrow), the program segmentation faults.
This code puts a check in to see if the index being references isnt the beginning index before data is shuffled along