-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nanoarrow: Update to 0.6.0 #1741
nanoarrow: Update to 0.6.0 #1741
Conversation
releases.json
Outdated
@@ -2464,6 +2464,7 @@ | |||
"nanoarrow" | |||
], | |||
"versions": [ | |||
"0.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think need to append -1 to the end of this
@WillAyd Are we forgetting to install a file? The tests seem to be passing for the platforms where |
I could be misreading but I think that error is strictly due to how we are mixing the RC tag with the git hash in this PR, and probably not something with our Meson configuration. To test the RC you might be able to replace |
Thank you for looking into it! It is a bummer we didn't get around to removing the Arrow C++ test dependency for this release (it will be gone by the next one). There are a number of checks where arrow appears to be found correctly...if you build + install without the tests do you get the correct version number? |
Yea sorry - that comment was ill-advised. Actually I think if you just change the version as described to match the git hash you will see more green. When we merged this originally not all of the checks were green anyway (Ubuntu, and the VisualStudio checks were in a red state). I'm guessing there might be something missing with the Arrow pkgconfig resolution on those platforms, but I don't think that is a blocker |
Yeah, I believe that is because Debian/Ubuntu still do not package apache-arrow at all, so while you could install it in ci_config.json for alpine and brew you could not do so for debian. There is nothing really to do about this, the failing CI does not indicate an actionable issue nor an issue in the wrap itself. |
Probably also a good idea to squash and force push. ;) Activating CI... |
c66e3fe
to
12b7698
Compare
I believe all these failures are related to installing Apache Arrow (the test dependency for which we'll remove in the next version)! |
Thanks for the ping. The macOS issue is bizarre (it appears to spend 4 hours installing everything from python to LLVM to boost to cmake to grpc from source and then bombs out merging the results?) |
I too was confused. Thank you! |
Just checking the nanoarrow 0.6.0 release candidate for issues prior to release!
cc @WillAyd