Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanoarrow: Update to 0.6.0 #1741

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

paleolimbot
Copy link
Contributor

@paleolimbot paleolimbot commented Oct 8, 2024

Just checking the nanoarrow 0.6.0 release candidate for issues prior to release!

cc @WillAyd

@paleolimbot paleolimbot changed the title nanoarrow: Check pre-0.6.0 release candidate nanoarrow: Check 0.6.0 release candidate Oct 8, 2024
releases.json Outdated
@@ -2464,6 +2464,7 @@
"nanoarrow"
],
"versions": [
"0.6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think need to append -1 to the end of this

@paleolimbot
Copy link
Contributor Author

@WillAyd Are we forgetting to install a file? The tests seem to be passing for the platforms where arrow can be installed but the installed version check seems to fail everywhere (e.g., https://github.com/mesonbuild/wrapdb/actions/runs/11237215557/job/31248856622?pr=1741#step:4:3606 ).

@WillAyd
Copy link
Contributor

WillAyd commented Oct 8, 2024

I could be misreading but I think that error is strictly due to how we are mixing the RC tag with the git hash in this PR, and probably not something with our Meson configuration.

To test the RC you might be able to replace 0.6.0-1 temporarily with 33d2c8b973d8f8f424e02ac92ddeaace2a92f8dd-1

@paleolimbot
Copy link
Contributor Author

Thank you for looking into it! It is a bummer we didn't get around to removing the Arrow C++ test dependency for this release (it will be gone by the next one). There are a number of checks where arrow appears to be found correctly...if you build + install without the tests do you get the correct version number?

@WillAyd
Copy link
Contributor

WillAyd commented Oct 8, 2024

Yea sorry - that comment was ill-advised. Actually I think if you just change the version as described to match the git hash you will see more green.

When we merged this originally not all of the checks were green anyway (Ubuntu, and the VisualStudio checks were in a red state). I'm guessing there might be something missing with the Arrow pkgconfig resolution on those platforms, but I don't think that is a blocker

@eli-schwartz
Copy link
Member

I'm guessing there might be something missing with the Arrow pkgconfig resolution on those platforms, but I don't think that is a blocker

Yeah, I believe that is because Debian/Ubuntu still do not package apache-arrow at all, so while you could install it in ci_config.json for alpine and brew you could not do so for debian. There is nothing really to do about this, the failing CI does not indicate an actionable issue nor an issue in the wrap itself.

@paleolimbot paleolimbot changed the title nanoarrow: Check 0.6.0 release candidate nanoarrow: Update to 0.6.0 Oct 13, 2024
@eli-schwartz
Copy link
Member

eli-schwartz commented Oct 13, 2024

Probably also a good idea to squash and force push. ;)

Activating CI...

@paleolimbot paleolimbot force-pushed the nanoarrow-0.6.0-update branch from c66e3fe to 12b7698 Compare October 13, 2024 04:10
@paleolimbot paleolimbot marked this pull request as ready for review October 13, 2024 04:10
@paleolimbot
Copy link
Contributor Author

I believe all these failures are related to installing Apache Arrow (the test dependency for which we'll remove in the next version)!

@eli-schwartz
Copy link
Member

Thanks for the ping. The macOS issue is bizarre (it appears to spend 4 hours installing everything from python to LLVM to boost to cmake to grpc from source and then bombs out merging the results?)

@eli-schwartz eli-schwartz merged commit 24cc76d into mesonbuild:master Oct 15, 2024
4 of 9 checks passed
@paleolimbot
Copy link
Contributor Author

I too was confused. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants