Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: don't trace requests #26

Merged
merged 1 commit into from
Feb 3, 2024
Merged

chore: don't trace requests #26

merged 1 commit into from
Feb 3, 2024

Conversation

gaspb
Copy link
Member

@gaspb gaspb commented Feb 3, 2024

Description

Tracing requests as a whole can be problematic when it comes to security (tokens etc) and gdpr (customer info etc)

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

@gaspb gaspb force-pushed the avoid-tracing-requests branch from 77c78f0 to c3a8570 Compare February 3, 2024 12:38
@gaspb gaspb force-pushed the avoid-tracing-requests branch from c3a8570 to cb1795e Compare February 3, 2024 12:39
@gaspb gaspb merged commit f2b49b6 into main Feb 3, 2024
5 checks passed
@gaspb gaspb deleted the avoid-tracing-requests branch February 3, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azhur azhur azhur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaspb @azhur