Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time split contour and overlay path template change #103

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Dec 17, 2024

Change Summary

  • Overlays are in /project/experiment/overlays instead of /project/experiment/contour/overlays (Breaking change)
  • get_overlay takes an optional timestep kwarg which can be used to filter. Behaviour without is identical to the existing behaviour.

Related issue number

closes #101

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added the enhancement New feature or request label Dec 17, 2024
@thorbjoernl thorbjoernl added this to the m2025-01 milestone Dec 17, 2024
@thorbjoernl thorbjoernl changed the title Time split contour Time split contour and overlay path template change Dec 17, 2024
@thorbjoernl thorbjoernl self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time-split contour files
1 participant