Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#350: override file_location #351

Merged
merged 3 commits into from
Jan 6, 2025
Merged

#350: override file_location #351

merged 3 commits into from
Jan 6, 2025

Conversation

mortenwh
Copy link
Collaborator

Summary: closes #350

Related issue:

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license (i.e., "License: This file is part of py-mmd-tools, licensed under the Apache License 2.0 (https://www.apache.org/licenses/LICENSE-2.0)")
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see https://s-enda-documentation.readthedocs.io/en/latest/general_conventions.html). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@mortenwh mortenwh requested a review from myggen December 19, 2024 13:42
@myggen
Copy link
Contributor

myggen commented Dec 27, 2024

Ser ikke hvordan jeg kan override file_location med kommandolinjeargument til nc2mmd.py ?

Copy link
Contributor

@myggen myggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok

nc2mmd.py --i ./arome_arctic_det_2_5km_20250105T00Z.nc --file_location /tmp/arome_arctic_det_2_5km_20250105T00Z.nc -o . -u https://thredds.met.no/thredds/dodsC/aromearcticarchive/2025/01/05/arome_arctic_det_vc_2_5km_20250105T03Z.nc.html && grep /tmp/arome arome_arctic_det_2_5km_20250105T00Z.xml <mmd:file_location>/tmp/arome_arctic_det_2_5km_20250105T00Z.nc</mmd:file_location>

@mortenwh mortenwh merged commit 15e2951 into master Jan 6, 2025
7 checks passed
@mortenwh mortenwh deleted the issue350_override_location branch January 6, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add override for file location in Nc_to_mmd.to_mmd
2 participants