Moving and shakin #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acme-cli is no longer a thing so point to micronaut-starter and Micronaut Launch instead.
Dependency upgrades
Instead of doing everything post app startup we can move some things into pre-app startup. Things moved: 1. Login and ordering a certificate if needed 2. If cert already downloaded and ready set it up Things that cannot be moved: 1. Authorizations, reason this cannot be moved is because it needs to be able to respond from requests from the ACME server.
jameskleeh
suggested changes
Jul 23, 2020
| public void orderCertificate(List<String> domains) throws AcmeException { | ||
| AtomicInteger orderRetryAttempts = new AtomicInteger(acmeConfiguration.getOrder().getRefreshAttempts()); | ||
|
|
||
| public Order orderCertificate(List<String> domains) throws AcmeException { |
There was a problem hiding this comment.
This is a breaking change. The original method signature must remain intact. You can create a new method for this purpose
|
@zendern I would like to resuscitate this PR. Are you still interested in pursuing these changes? |
jeremyg484
previously approved these changes
Nov 18, 2023
jeremyg484
approved these changes
Nov 22, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Instead of doing everything post app startup we can move some things into pre-app startup.
Things moved to happen at
StartupEventevent:Things that cannot be moved and will happen at
ApplicationStartupEventevent:able to respond from requests from the ACME server.