Fix Azure HTTP functions when you define a contextPath #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micronaut Azure HTTP functions do not work if you define a micronaut.server.contextPath. When defined the context path is duplicated.
|
Kudos, SonarCloud Quality Gate passed! |
|
Ping @sdelamo |
timyates
added a commit
that referenced
this pull request
Jun 21, 2023
|
@sdelamo ping! 🛎️😉 |
|
I think it is better to leave it as it is for Micronaut Framework 3 since this is fixed in Micronaut Framework 4 with the changes to |
|
Could we merge this in to fix Micronaut 3, but then not merge it up for Micronaut 4? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #476 with a test
I couldn't get an in-module test to work, so I spun out a test-suite to test it