Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] fix retrain on sequence dataset #6414
base: master
Are you sure you want to change the base?
[python-package] fix retrain on sequence dataset #6414
Changes from 2 commits
2b7811b
a07800c
3ac186c
ecd5746
b3bcf37
48f062c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you move this test, please use the cached version of this function.
LightGBM/tests/python_package_test/test_basic.py
Line 221 in 830763d
LightGBM/tests/python_package_test/test_basic.py
Line 221 in 830763d
That'll make the tests a little faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this test stricter than simply "training runs without error". Could you add assertions after training checking that:
model1
andmodel2
have the expected number of treesLightGBM/tests/python_package_test/test_basic.py
Lines 50 to 51 in 830763d
dataset
has the expected dimensions (feature names, number of rows)