Upgrade to dotnet8, and new plugin to list project dependencies #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Anduin2017
previously approved these changes
Sep 20, 2023
Anduin2017
reviewed
Sep 20, 2023
src/NugetNinja.UselessPackageReferencePlugin/Services/UselessPackageReferenceDetector.cs
Outdated
Show resolved
Hide resolved
Anduin2017
reviewed
Sep 20, 2023
…nd query description from nuget
ErikApption
changed the title
|
Bigger update... I moved solution to net 8 and since dotnet list package is broken with shproj, I decided to re-use this code to generate an excel file with all the packages. |
|
Maybe also updating this file is needed: https://github.com/microsoft/NugetNinja/blob/main/.github/workflows/build.yml |
done - can you rerun the workflows? |
Anduin2017
approved these changes
Nov 13, 2024
|
Thank you for the contribution!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the removal of useless packages doesn't track versions and can remove a higher version dependency simply because it is a transitive one. This small fix prevents this issue.