Fixed incompatible property error reporting in `hasExcessProperties` under `exactOptionalPropertyTypes` #60716

Andarist · 2024-12-09T11:11:22Z

…under `exactOptionalPropertyTypes`

Andarist · 2024-12-09T11:11:53Z

src/compiler/checker.ts

-            const targetIsOptional = strictNullChecks && !!(getCheckFlags(targetProp) & CheckFlags.Partial);
-            const effectiveTarget = addOptionality(getNonMissingTypeOfSymbol(targetProp), /*isProperty*/ false, targetIsOptional);


I'm not particularly sure about this change but tests are unaffected

jakebailey · 2024-12-09T21:05:07Z

@typescript-bot test it

typescript-bot · 2024-12-09T21:05:12Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-12-09T21:26:14Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-12-09T21:26:38Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60716/merge:

Everything looks good!

typescript-bot · 2024-12-09T21:48:22Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,069k (± 0.07%)}	_{193,629k (± 0.78%)}	_~	_192,981k	_196,699k	_{p=0.471 n=6}
_{Parse Time}	_{1.31s (± 0.84%)}	_{1.31s (± 0.93%)}	_~	_1.29s	_1.32s	_{p=0.677 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.79s (± 0.38%)}	_{9.78s (± 0.26%)}	_~	_9.73s	_9.80s	_{p=0.687 n=6}
_{Emit Time}	_{2.73s (± 0.60%)}	_{2.74s (± 0.81%)}	_~	_2.72s	_2.77s	_{p=0.806 n=6}
_{Total Time}	_{14.55s (± 0.23%)}	_{14.54s (± 0.24%)}	_~	_14.50s	_14.59s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,995k (± 0.01%)}	_{1,226,004k (± 0.01%)}	_~	_1,225,905k	_1,226,145k	_{p=1.000 n=6}
_{Parse Time}	_{8.03s (± 0.83%)}	_{8.08s (± 0.42%)}	_~	_8.02s	_8.12s	_{p=0.228 n=6}
_{Bind Time}	_{2.25s (± 0.61%)}	_{2.26s (± 0.66%)}	_~	_2.25s	_2.29s	_{p=0.615 n=6}
_{Check Time}	_{38.13s (± 0.24%)}	_{38.14s (± 0.59%)}	_~	_37.84s	_38.39s	_{p=0.810 n=6}
_{Emit Time}	_{18.17s (± 1.12%)}	_{18.31s (± 0.66%)}	_~	_18.14s	_18.50s	_{p=0.336 n=6}
_{Total Time}	_{66.58s (± 0.42%)}	_{66.79s (± 0.47%)}	_~	_66.38s	_67.16s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,447,028	_2,447,028	_~	_~	_~	_{p=1.000 n=6}
_Types	_896,160	_896,160	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,318,463k (± 0.00%)}	_{2,318,405k (± 0.00%)}	_~	_2,318,346k	_2,318,455k	_{p=0.173 n=6}
_{Parse Time}	_{9.43s (± 0.21%)}	_{9.42s (± 0.21%)}	_~	_9.39s	_9.44s	_{p=0.368 n=6}
_{Bind Time}	_{2.23s (± 0.55%)}	_{2.22s (± 0.64%)}	_~	_2.20s	_2.24s	_{p=0.564 n=6}
_{Check Time}	_{73.34s (± 0.29%)}	_{73.39s (± 0.31%)}	_~	_73.06s	_73.73s	_{p=0.936 n=6}
_{Emit Time}	_{0.29s (± 2.85%)}	_{0.28s (± 1.82%)}	_~	_0.28s	_0.29s	_{p=0.523 n=6}
_{Total Time}	_{85.28s (± 0.25%)}	_{85.31s (± 0.27%)}	_~	_84.96s	_85.63s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,331	_1,225,330	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,569	_266,569	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,414,635k (± 6.14%)}	_{2,354,400k (± 0.02%)}	_~	_2,353,573k	_2,355,023k	_{p=0.575 n=6}
_{Parse Time}	_{5.23s (± 0.41%)}	_{5.23s (± 0.78%)}	_~	_5.18s	_5.30s	_{p=0.630 n=6}
_{Bind Time}	_{1.78s (± 1.18%)}	_{1.77s (± 1.41%)}	_~	_1.73s	_1.80s	_{p=0.808 n=6}
_{Check Time}	_{35.25s (± 0.73%)}	_{35.21s (± 0.36%)}	_~	_35.06s	_35.34s	_{p=1.000 n=6}
_{Emit Time}	_{2.97s (± 1.24%)}	_{3.01s (± 2.39%)}	_~	_2.95s	_3.15s	_{p=0.172 n=6}
_{Total Time}	_{45.24s (± 0.55%)}	_{45.23s (± 0.36%)}	_~	_45.03s	_45.42s	_{p=1.000 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,331	_1,225,330	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,569	_266,569	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,908,155k (±12.87%)}	_{2,907,939k (±12.86%)}	_~	_2,423,484k	_3,149,896k	_{p=0.936 n=6}
_{Parse Time}	_{6.94s (± 1.56%)}	_{6.93s (± 2.23%)}	_~	_6.72s	_7.09s	_{p=0.936 n=6}
_{Bind Time}	_{2.18s (± 1.43%)}	_{2.15s (± 1.78%)}	_~	_2.10s	_2.21s	_{p=0.196 n=6}
_{Check Time}	_{42.66s (± 0.39%)}	_{42.84s (± 0.22%)}	_{+0.18s (+ 0.42%)}	_42.71s	_42.99s	_{p=0.045 n=6}
_{Emit Time}	_{3.48s (± 0.99%)}	_{3.55s (± 2.45%)}	_~	_3.48s	_3.72s	_{p=0.078 n=6}
_{Total Time}	_{55.27s (± 0.47%)}	_{55.50s (± 0.31%)}	_~	_55.17s	_55.66s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,270	_262,269	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,628	_106,628	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,824k (± 0.02%)}	_{439,882k (± 0.03%)}	_~	_439,694k	_440,076k	_{p=0.575 n=6}
_{Parse Time}	_{2.89s (± 0.40%)}	_{2.89s (± 0.18%)}	_~	_2.88s	_2.89s	_{p=0.542 n=6}
_{Bind Time}	_1.10s	_1.10s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{15.73s (± 0.32%)}	_{15.78s (± 0.41%)}	_~	_15.68s	_15.85s	_{p=0.228 n=6}
_{Emit Time}	_{1.30s (± 1.73%)}	_{1.32s (± 1.49%)}	_~	_1.29s	_1.34s	_{p=0.514 n=6}
_{Total Time}	_{21.03s (± 0.24%)}	_{21.08s (± 0.30%)}	_~	_21.01s	_21.15s	_{p=0.261 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,585k (± 0.01%)}	_{371,561k (± 0.01%)}	_~	_371,521k	_371,646k	_{p=0.199 n=6}
_{Parse Time}	_{2.90s (± 0.89%)}	_{2.88s (± 1.65%)}	_~	_2.84s	_2.97s	_{p=0.360 n=6}
_{Bind Time}	_{1.59s (± 1.24%)}	_{1.59s (± 1.61%)}	_~	_1.55s	_1.62s	_{p=0.806 n=6}
_{Check Time}	_{16.46s (± 0.31%)}	_{16.50s (± 0.44%)}	_~	_16.39s	_16.58s	_{p=0.295 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{20.95s (± 0.27%)}	_{20.96s (± 0.53%)}	_~	_20.84s	_21.10s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,197,814	_3,197,814	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,099,278	_1,099,278	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,271,847k (± 0.01%)}	_{3,271,931k (± 0.01%)}	_~	_3,271,349k	_3,272,427k	_{p=0.810 n=6}
_{Parse Time}	_{14.09s (± 0.71%)}	_{14.22s (± 0.68%)}	_{+0.13s (+ 0.95%)}	_14.13s	_14.40s	_{p=0.016 n=6}
_{Bind Time}	_{4.84s (±13.93%)}	_{4.51s (± 0.52%)}	_~	_4.48s	_4.55s	_{p=0.106 n=6}
_{Check Time}	_{87.93s (± 4.22%)}	_{87.93s (± 1.98%)}	_~	_86.05s	_89.99s	_{p=0.936 n=6}
_{Emit Time}	_{27.40s (± 8.50%)}	_{27.96s (± 2.70%)}	_~	_27.21s	_28.72s	_{p=0.810 n=6}
_{Total Time}	_{134.27s (± 1.35%)}	_{134.62s (± 1.30%)}	_~	_132.09s	_137.10s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,747	_288,747	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,158	_117,158	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,037k (± 0.03%)}	_{440,966k (± 0.02%)}	_~	_440,772k	_441,088k	_{p=0.575 n=6}
_{Parse Time}	_{4.06s (± 1.46%)}	_{4.07s (± 0.87%)}	_~	_4.02s	_4.12s	_{p=0.468 n=6}
_{Bind Time}	_{1.75s (± 1.51%)}	_{1.76s (± 0.78%)}	_~	_1.73s	_1.77s	_{p=0.803 n=6}
_{Check Time}	_{18.84s (± 0.26%)}	_{18.83s (± 0.69%)}	_~	_18.62s	_19.03s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.66s (± 0.51%)}	_{24.66s (± 0.62%)}	_~	_24.42s	_24.89s	_{p=0.748 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,233	_552,233	_~	_~	_~	_{p=1.000 n=6}
_Types	_184,971	_184,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{492,369k (± 0.01%)}	_{492,340k (± 0.04%)}	_~	_492,004k	_492,631k	_{p=0.689 n=6}
_{Parse Time}	_{3.41s (± 0.60%)}	_{3.43s (± 0.74%)}	_~	_3.40s	_3.47s	_{p=0.292 n=6}
_{Bind Time}	_{1.18s (± 1.73%)}	_{1.18s (± 1.03%)}	_~	_1.16s	_1.19s	_{p=0.871 n=6}
_{Check Time}	_{19.45s (± 0.57%)}	_{19.46s (± 0.67%)}	_~	_19.37s	_19.72s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.04s (± 0.49%)}	_{24.06s (± 0.50%)}	_~	_23.99s	_24.29s	_{p=0.687 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-12-09T22:32:00Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60716/merge:

Everything looks good!

Fixed incompatible property error reporting in hasExcessProperties …

c304970

…under `exactOptionalPropertyTypes`

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 9, 2024

Andarist commented Dec 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed incompatible property error reporting in `hasExcessProperties` under `exactOptionalPropertyTypes` #60716

Fixed incompatible property error reporting in `hasExcessProperties` under `exactOptionalPropertyTypes` #60716

Andarist commented Dec 9, 2024

Andarist Dec 9, 2024

jakebailey commented Dec 9, 2024

typescript-bot commented Dec 9, 2024 •

edited

Loading

typescript-bot commented Dec 9, 2024

typescript-bot commented Dec 9, 2024

typescript-bot commented Dec 9, 2024

tsc

typescript-bot commented Dec 9, 2024

		const targetIsOptional = strictNullChecks && !!(getCheckFlags(targetProp) & CheckFlags.Partial);
		const effectiveTarget = addOptionality(getNonMissingTypeOfSymbol(targetProp), /isProperty/ false, targetIsOptional);

Fixed incompatible property error reporting in hasExcessProperties under exactOptionalPropertyTypes #60716

Are you sure you want to change the base?

Fixed incompatible property error reporting in hasExcessProperties under exactOptionalPropertyTypes #60716

Conversation

Andarist commented Dec 9, 2024

Andarist Dec 9, 2024

Choose a reason for hiding this comment

jakebailey commented Dec 9, 2024

typescript-bot commented Dec 9, 2024 • edited Loading

typescript-bot commented Dec 9, 2024

typescript-bot commented Dec 9, 2024

typescript-bot commented Dec 9, 2024

tsc

typescript-bot commented Dec 9, 2024

Fixed incompatible property error reporting in `hasExcessProperties` under `exactOptionalPropertyTypes` #60716

Fixed incompatible property error reporting in `hasExcessProperties` under `exactOptionalPropertyTypes` #60716

typescript-bot commented Dec 9, 2024 •

edited

Loading