Skip `verifyCompilerOptions` when possible on program updates #60754

andrewbranch · 2024-12-13T00:23:58Z

Related to #60633

Reusing config diagnostics lowers the update time in the linked issue scenario from ~70ms to ~50ms on my M2 Mac.

…dentical config files

andrewbranch · 2024-12-13T00:25:00Z

typescript-bot · 2024-12-13T00:25:05Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results

typescript-bot · 2024-12-13T01:07:43Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{196,145k (± 0.83%)}	_{195,639k (± 0.96%)}	_~	_193,189k	_196,904k	_{p=1.000 n=6}
_{Parse Time}	_{1.61s (± 0.91%)}	_{1.60s (± 1.18%)}	_~	_1.58s	_1.62s	_{p=0.330 n=6}
_{Bind Time}	_{0.88s (± 1.88%)}	_{0.86s (± 0.94%)}	_~	_0.85s	_0.87s	_{p=0.133 n=6}
_{Check Time}	_{11.77s (± 0.46%)}	_{11.75s (± 0.24%)}	_~	_11.71s	_11.78s	_{p=0.465 n=6}
_{Emit Time}	_{3.39s (± 3.96%)}	_{3.29s (± 0.83%)}	_~	_3.26s	_3.32s	_{p=0.126 n=6}
_{Total Time}	_{17.65s (± 0.76%)}	_{17.51s (± 0.27%)}	_{-0.14s (- 0.78%)}	_17.46s	_17.58s	_{p=0.045 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,035k (± 0.00%)}	_{1,225,995k (± 0.00%)}	_~	_1,225,924k	_1,226,033k	_{p=0.378 n=6}
_{Parse Time}	_{8.11s (± 0.91%)}	_{8.10s (± 0.98%)}	_~	_7.99s	_8.17s	_{p=0.688 n=6}
_{Bind Time}	_{2.29s (± 1.15%)}	_{2.27s (± 1.10%)}	_~	_2.25s	_2.31s	_{p=0.292 n=6}
_{Check Time}	_{38.10s (± 0.55%)}	_{38.22s (± 0.45%)}	_~	_38.08s	_38.54s	_{p=0.230 n=6}
_{Emit Time}	_{18.34s (± 0.38%)}	_{18.30s (± 0.63%)}	_~	_18.14s	_18.42s	_{p=0.687 n=6}
_{Total Time}	_{66.84s (± 0.42%)}	_{66.88s (± 0.28%)}	_~	_66.63s	_67.07s	_{p=0.521 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,448,065	_2,448,065	_~	_~	_~	_{p=1.000 n=6}
_Types	_896,131	_896,131	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,320,429k (± 0.00%)}	_{2,320,454k (± 0.00%)}	_~	_2,320,363k	_2,320,554k	_{p=0.936 n=6}
_{Parse Time}	_{11.32s (± 0.23%)}	_{11.33s (± 0.56%)}	_~	_11.27s	_11.45s	_{p=0.747 n=6}
_{Bind Time}	_{2.66s (± 0.19%)}	_{2.65s (± 0.46%)}	_~	_2.63s	_2.66s	_{p=0.070 n=6}
_{Check Time}	_{87.80s (± 1.22%)}	_{87.77s (± 1.41%)}	_~	_86.90s	_90.21s	_{p=0.936 n=6}
_{Emit Time}	_{0.35s (± 2.55%)}	_{0.34s (± 3.01%)}	_~	_0.33s	_0.35s	_{p=0.344 n=6}
_{Total Time}	_{102.12s (± 1.03%)}	_{102.10s (± 1.19%)}	_~	_101.23s	_104.49s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,331	_1,225,378	_{+47 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,569	_266,579	_{+10 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,084,905k (± 0.02%)}	_{2,963,594k (±10.02%)}	_~	_2,356,552k	_3,085,707k	_{p=0.936 n=6}
_{Parse Time}	_{6.78s (± 0.36%)}	_{6.77s (± 1.56%)}	_~	_6.58s	_6.87s	_{p=0.575 n=6}
_{Bind Time}	_{2.14s (± 1.46%)}	_{2.13s (± 1.14%)}	_~	_2.11s	_2.17s	_{p=0.809 n=6}
_{Check Time}	_{42.72s (± 0.40%)}	_{42.76s (± 0.21%)}	_~	_42.63s	_42.86s	_{p=0.423 n=6}
_{Emit Time}	_{3.44s (± 1.53%)}	_{3.44s (± 2.90%)}	_~	_3.29s	_3.57s	_{p=0.748 n=6}
_{Total Time}	_{55.07s (± 0.26%)}	_{55.11s (± 0.23%)}	_~	_54.97s	_55.29s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,331	_1,225,378	_{+47 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,569	_266,579	_{+10 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,029,482k (± 9.76%)}	_{2,787,116k (±14.26%)}	_~	_2,423,383k	_3,150,646k	_{p=0.298 n=6}
_{Parse Time}	_{6.98s (± 1.54%)}	_{6.93s (± 2.26%)}	_~	_6.76s	_7.13s	_{p=0.810 n=6}
_{Bind Time}	_{2.15s (± 1.64%)}	_{2.16s (± 2.33%)}	_~	_2.11s	_2.25s	_{p=0.809 n=6}
_{Check Time}	_{42.93s (± 0.82%)}	_{42.68s (± 0.28%)}	_~	_42.56s	_42.89s	_{p=0.093 n=6}
_{Emit Time}	_{3.47s (± 2.14%)}	_{3.52s (± 3.45%)}	_~	_3.40s	_3.69s	_{p=0.689 n=6}
_{Total Time}	_{55.53s (± 0.77%)}	_{55.30s (± 0.32%)}	_~	_55.01s	_55.55s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,270	_262,284	_{+14 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,628	_106,635	_{+7 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{439,885k (± 0.01%)}	_{439,918k (± 0.01%)}	_~	_439,850k	_440,013k	_{p=0.575 n=6}
_{Parse Time}	_{3.54s (± 0.49%)}	_{3.54s (± 1.25%)}	_~	_3.48s	_3.60s	_{p=0.936 n=6}
_{Bind Time}	_{1.32s (± 0.31%)}	_{1.32s (± 0.79%)}	_~	_1.31s	_1.34s	_{p=0.528 n=6}
_{Check Time}	_{18.93s (± 0.33%)}	_{19.01s (± 0.45%)}	_~	_18.90s	_19.12s	_{p=0.127 n=6}
_{Emit Time}	_{1.53s (± 1.29%)}	_{1.53s (± 0.64%)}	_~	_1.52s	_1.54s	_{p=0.802 n=6}
_{Total Time}	_{25.32s (± 0.29%)}	_{25.41s (± 0.42%)}	_~	_25.24s	_25.52s	_{p=0.199 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,625k (± 0.04%)}	_{371,574k (± 0.01%)}	_~	_371,532k	_371,638k	_{p=0.936 n=6}
_{Parse Time}	_{2.89s (± 0.56%)}	_{2.90s (± 1.19%)}	_~	_2.85s	_2.95s	_{p=0.686 n=6}
_{Bind Time}	_{1.59s (± 1.23%)}	_{1.59s (± 0.40%)}	_~	_1.58s	_1.60s	_{p=1.000 n=6}
_{Check Time}	_{16.49s (± 0.26%)}	_{16.43s (± 0.29%)}	_~	_16.37s	_16.48s	_{p=0.065 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.98s (± 0.21%)}	_{20.92s (± 0.23%)}	_~	_20.83s	_20.97s	_{p=0.077 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,215,020	_3,215,020	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,106,063	_1,106,063	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,281,141k (± 0.01%)}	_{3,280,975k (± 0.01%)}	_~	_3,280,622k	_3,281,467k	_{p=0.810 n=6}
_{Parse Time}	_{14.20s (± 0.51%)}	_{14.15s (± 0.61%)}	_~	_14.04s	_14.29s	_{p=0.196 n=6}
_{Bind Time}	_{4.70s (± 2.74%)}	_{4.57s (± 2.41%)}	_~	_4.50s	_4.79s	_{p=0.107 n=6}
_{Check Time}	_{86.80s (± 0.36%)}	_{87.52s (± 1.18%)}	_~	_86.76s	_89.55s	_{p=0.093 n=6}
_{Emit Time}	_{28.29s (± 2.62%)}	_{28.36s (± 2.14%)}	_~	_27.50s	_29.12s	_{p=1.000 n=6}
_{Total Time}	_{133.99s (± 0.77%)}	_{134.59s (± 0.68%)}	_~	_133.45s	_135.95s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,747	_288,747	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,158	_117,158	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,093k (± 0.03%)}	_{440,960k (± 0.03%)}	_~	_440,793k	_441,175k	_{p=0.128 n=6}
_{Parse Time}	_{4.10s (± 0.95%)}	_{4.10s (± 1.32%)}	_~	_4.03s	_4.16s	_{p=0.936 n=6}
_{Bind Time}	_{1.77s (± 1.31%)}	_{1.78s (± 0.84%)}	_~	_1.77s	_1.81s	_{p=0.292 n=6}
_{Check Time}	_{18.92s (± 0.28%)}	_{18.85s (± 0.34%)}	_~	_18.78s	_18.95s	_{p=0.108 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{24.79s (± 0.32%)}	_{24.74s (± 0.33%)}	_~	_24.61s	_24.82s	_{p=0.378 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,233	_552,233	_~	_~	_~	_{p=1.000 n=6}
_Types	_184,971	_184,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{492,247k (± 0.01%)}	_{492,234k (± 0.01%)}	_~	_492,205k	_492,329k	_{p=1.000 n=6}
_{Parse Time}	_2.76s	_{2.76s (± 0.15%)}	_~	_2.75s	_2.76s	_{p=0.405 n=6}
_{Bind Time}	_0.96s	_0.96s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{16.18s (± 0.26%)}	_{16.18s (± 0.28%)}	_~	_16.11s	_16.23s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.89s (± 0.22%)}	_{19.89s (± 0.25%)}	_~	_19.82s	_19.95s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,316ms (± 0.28%)}	_{2,314ms (± 0.28%)}	_~	_2,305ms	_2,322ms	_{p=0.573 n=6}
_{Req 2 - geterr}	_{5,290ms (± 0.62%)}	_{5,304ms (± 0.35%)}	_~	_5,284ms	_5,337ms	_{p=0.378 n=6}
_{Req 3 - references}	_{262ms (± 1.50%)}	_{266ms (± 1.27%)}	_~	_262ms	_269ms	_{p=0.061 n=6}
_{Req 4 - navto}	_{227ms (± 0.78%)}	_{226ms (± 0.43%)}	_~	_225ms	_228ms	_{p=0.799 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 7.94%)}	_{76ms (± 0.68%)}	_~	_75ms	_76ms	_{p=0.142 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,420ms (± 1.89%)}	_{2,444ms (± 1.32%)}	_~	_2,393ms	_2,470ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{4,018ms (± 0.58%)}	_{4,030ms (± 0.42%)}	_~	_4,009ms	_4,051ms	_{p=0.378 n=6}
_{Req 3 - references}	_{281ms (± 0.27%)}	_{280ms (± 1.21%)}	_~	_273ms	_282ms	_{p=0.454 n=6}
_{Req 4 - navto}	_{227ms (± 0.18%)}	_{227ms (± 0.18%)}	_~	_226ms	_227ms	_{p=0.218 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 2.73%)}	_{85ms (± 4.47%)}	_~	_77ms	_87ms	_{p=0.451 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,276ms (± 0.29%)}	_{5,275ms (± 0.27%)}	_~	_5,250ms	_5,293ms	_{p=0.809 n=6}
_{Req 2 - geterr}	_{1,150ms (± 1.45%)}	_{1,154ms (± 1.24%)}	_~	_1,139ms	_1,175ms	_{p=0.630 n=6}
_{Req 3 - references}	_{83ms (± 0.62%)}	_{81ms (± 3.77%)}	_~	_75ms	_83ms	_{p=0.247 n=6}
_{Req 4 - navto}	_{450ms (± 0.51%)}	_{449ms (± 0.48%)}	_~	_447ms	_453ms	_{p=0.566 n=6}
_{Req 5 - completionInfo count}	_3,450	_3,450	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{848ms (± 2.03%)}	_{842ms (± 1.01%)}	_~	_832ms	_854ms	_{p=0.810 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{160.01ms (± 0.22%)}	_{160.16ms (± 0.21%)}	_{+0.15ms (+ 0.09%)}	_158.98ms	_164.22ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{233.55ms (± 0.16%)}	_{233.40ms (± 0.16%)}	_{-0.16ms (- 0.07%)}	_232.08ms	_237.28ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.47ms (± 0.15%)}	_{229.46ms (± 0.16%)}	_~	_227.92ms	_235.51ms	_{p=0.534 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.44ms (± 0.16%)}	_{228.40ms (± 0.19%)}	_{-0.04ms (- 0.02%)}	_226.77ms	_235.45ms	_{p=0.032 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

DanielRosenwasser · 2024-12-13T18:58:53Z

src/compiler/program.ts

@@ -2722,6 +2735,14 @@ export function createProgram(rootNamesOrOptions: readonly string[] | CreateProg
            filesByName.set(path, filesByName.get(oldFile.path));
        });

+        if (
+            oldOptions.configFile && oldOptions.configFile === options.configFile ||
+            !oldOptions.configFile && !options.configFile && !optionsHaveChanges(oldOptions, options, optionDeclarations)


I think you need to check that the program's file set are the same as well, because a new or deleted file can invalidate/introduce some errors. Maybe it's done elsewhere, but it would be good to add a test for that.

Early returns above handle that (we wouldn’t be at StructureIsReused.Completely if that happened)

DanielRosenwasser · 2024-12-13T23:42:25Z

@typescript-bot pack this

typescript-bot · 2024-12-13T23:42:29Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-12-13T23:44:07Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164389/artifacts?artifactName=tgz&fileId=B0A5033E72FA516769924862354F3C9291EF74999415900BE634CCF66DFD3DCF02&fileName=/typescript-5.8.0-insiders.20241213.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

DanielRosenwasser · 2024-12-18T20:10:10Z

src/compiler/program.ts

+        const isConfigIdentical = oldOptions.configFile && oldOptions.configFile === options.configFile
+            || !oldOptions.configFile && !options.configFile && !optionsHaveChanges(oldOptions, options, optionDeclarations);


I wanted to suggest

Suggested change

const isConfigIdentical = oldOptions.configFile && oldOptions.configFile === options.configFile

|| !oldOptions.configFile && !options.configFile && !optionsHaveChanges(oldOptions, options, optionDeclarations);

// Reuse if both have an identical config file,

// or neither have a config but the options have changed.

const isConfigIdentical = oldOptions.configFile === options.configFile && (

options.configFile || !optionsHaveChanges(oldOptions, options, optionDeclarations))

But now the comment is really explaining what the current code is more clearly doing. That said, when do you end up in a situation where neither has a configFile? Inferred projects?

Yeah, possibly—I was also wondering about tsc --watch without -p but I honestly don’t know for sure

Reuse config diagnostics between programs with reused structure and i…

2432b01

…dentical config files

typescript-bot assigned andrewbranch Dec 13, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 13, 2024

Remove debug change

88149ba

DanielRosenwasser reviewed Dec 13, 2024

View reviewed changes

This was referenced Dec 16, 2024

UpdateProjectIfDirty is slow on large projects #60633

Open

Combined update graph experiments #60800

Open

andrewbranch added 3 commits December 18, 2024 08:28

Extract reusable diagnostic state to separate object

233f344

Fix API

2341668

Knip

1221256

andrewbranch changed the title ~~updateGraph perf experiments~~ Skip verifyCompilerOptions when possible on program updates Dec 18, 2024

andrewbranch marked this pull request as ready for review December 18, 2024 17:40

DanielRosenwasser reviewed Dec 18, 2024

View reviewed changes

andrewbranch requested review from DanielRosenwasser, weswigham and jakebailey December 18, 2024 20:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip `verifyCompilerOptions` when possible on program updates #60754

Skip `verifyCompilerOptions` when possible on program updates #60754

andrewbranch commented Dec 13, 2024 •

edited

Loading

andrewbranch commented Dec 13, 2024

typescript-bot commented Dec 13, 2024 •

edited

Loading

typescript-bot commented Dec 13, 2024

tsc

tsserver

startup

DanielRosenwasser Dec 13, 2024

andrewbranch Dec 13, 2024

DanielRosenwasser commented Dec 13, 2024

typescript-bot commented Dec 13, 2024 •

edited

Loading

typescript-bot commented Dec 13, 2024 •

edited

Loading

DanielRosenwasser Dec 18, 2024

andrewbranch Dec 18, 2024

		const isConfigIdentical = oldOptions.configFile && oldOptions.configFile === options.configFile
		\|\| !oldOptions.configFile && !options.configFile && !optionsHaveChanges(oldOptions, options, optionDeclarations);

-        const isConfigIdentical = oldOptions.configFile && oldOptions.configFile === options.configFile
-            || !oldOptions.configFile && !options.configFile && !optionsHaveChanges(oldOptions, options, optionDeclarations);
+        // Reuse if both have an identical config file,
+        // or neither have a config but the options have changed.
+        const isConfigIdentical = oldOptions.configFile === options.configFile && (
+            options.configFile || !optionsHaveChanges(oldOptions, options, optionDeclarations))

Skip verifyCompilerOptions when possible on program updates #60754

Are you sure you want to change the base?

Skip verifyCompilerOptions when possible on program updates #60754

Conversation

andrewbranch commented Dec 13, 2024 • edited Loading

andrewbranch commented Dec 13, 2024

typescript-bot commented Dec 13, 2024 • edited Loading

typescript-bot commented Dec 13, 2024

tsc

tsserver

startup

DanielRosenwasser Dec 13, 2024

Choose a reason for hiding this comment

andrewbranch Dec 13, 2024

Choose a reason for hiding this comment

DanielRosenwasser commented Dec 13, 2024

typescript-bot commented Dec 13, 2024 • edited Loading

typescript-bot commented Dec 13, 2024 • edited Loading

DanielRosenwasser Dec 18, 2024

Choose a reason for hiding this comment

andrewbranch Dec 18, 2024

Choose a reason for hiding this comment

Skip `verifyCompilerOptions` when possible on program updates #60754

Skip `verifyCompilerOptions` when possible on program updates #60754

andrewbranch commented Dec 13, 2024 •

edited

Loading

typescript-bot commented Dec 13, 2024 •

edited

Loading

typescript-bot commented Dec 13, 2024 •

edited

Loading

typescript-bot commented Dec 13, 2024 •

edited

Loading