Compute more precise syntactic truthy semantics for comma expressions #60830

Andarist · 2024-12-20T09:42:42Z

given the same thing was merged for syntactic nullish semantics (and its corresponding issue was accepted beforehand), I think it only makes sense to handle this for truthy semantics as well for consistency, cc @jakebailey

DanielRosenwasser · 2024-12-22T00:28:27Z

@typescript-bot test it

typescript-bot · 2024-12-22T00:28:31Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-12-22T00:48:26Z

@DanielRosenwasser Here are the results of running the user tests with tsc comparing main and refs/pull/60830/merge:

Everything looks good!

typescript-bot · 2024-12-22T00:50:03Z

Hey @DanielRosenwasser, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-12-22T01:10:32Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,621k (± 0.78%)}	_{194,230k (± 0.96%)}	_~	_193,005k	_196,664k	_{p=0.173 n=6}
_{Parse Time}	_{1.30s (± 0.69%)}	_{1.31s (± 0.89%)}	_~	_1.29s	_1.32s	_{p=0.082 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.80s (± 0.49%)}	_{9.79s (± 0.39%)}	_~	_9.74s	_9.84s	_{p=0.809 n=6}
_{Emit Time}	_{2.73s (± 0.63%)}	_{2.73s (± 0.50%)}	_~	_2.71s	_2.74s	_{p=0.934 n=6}
_{Total Time}	_{14.54s (± 0.34%)}	_{14.55s (± 0.26%)}	_~	_14.48s	_14.58s	_{p=0.744 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,818k (± 0.01%)}	_{1,225,830k (± 0.00%)}	_~	_1,225,798k	_1,225,865k	_{p=0.689 n=6}
_{Parse Time}	_{6.63s (± 0.42%)}	_{6.64s (± 0.41%)}	_~	_6.60s	_6.67s	_{p=1.000 n=6}
_{Bind Time}	_{1.89s (± 0.27%)}	_{1.89s (± 0.27%)}	_~	_1.88s	_1.89s	_{p=1.000 n=6}
_{Check Time}	_{32.00s (± 0.28%)}	_{32.02s (± 0.52%)}	_~	_31.74s	_32.18s	_{p=0.688 n=6}
_{Emit Time}	_{15.17s (± 0.42%)}	_{15.20s (± 0.49%)}	_~	_15.13s	_15.30s	_{p=0.630 n=6}
_{Total Time}	_{55.70s (± 0.22%)}	_{55.74s (± 0.43%)}	_~	_55.37s	_56.01s	_{p=0.573 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,449,218	_2,449,218	_~	_~	_~	_{p=1.000 n=6}
_Types	_896,453	_896,453	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,321,022k (± 0.00%)}	_{2,321,017k (± 0.00%)}	_~	_2,320,972k	_2,321,099k	_{p=0.521 n=6}
_{Parse Time}	_{9.42s (± 0.33%)}	_{9.42s (± 0.18%)}	_~	_9.40s	_9.44s	_{p=0.871 n=6}
_{Bind Time}	_{2.23s (± 0.57%)}	_{2.24s (± 0.28%)}	_~	_2.23s	_2.25s	_{p=0.153 n=6}
_{Check Time}	_{73.47s (± 0.51%)}	_{73.50s (± 0.75%)}	_~	_72.82s	_74.48s	_{p=0.810 n=6}
_{Emit Time}	_{0.28s (± 3.53%)}	_{0.28s (± 2.26%)}	_~	_0.27s	_0.29s	_{p=0.733 n=6}
_{Total Time}	_{85.40s (± 0.46%)}	_{85.44s (± 0.64%)}	_~	_84.78s	_86.42s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,880	_1,226,880	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,745	_266,745	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,845,923k (±13.20%)}	_{2,966,772k (±10.00%)}	_~	_2,360,588k	_3,088,829k	_{p=1.000 n=6}
_{Parse Time}	_{6.75s (± 2.23%)}	_{6.80s (± 0.99%)}	_~	_6.69s	_6.86s	_{p=0.689 n=6}
_{Bind Time}	_{2.15s (± 0.64%)}	_{2.13s (± 0.97%)}	_~	_2.11s	_2.17s	_{p=0.198 n=6}
_{Check Time}	_{43.00s (± 0.49%)}	_{42.92s (± 0.54%)}	_~	_42.69s	_43.32s	_{p=0.575 n=6}
_{Emit Time}	_{3.50s (± 4.37%)}	_{3.55s (± 1.70%)}	_~	_3.49s	_3.63s	_{p=0.378 n=6}
_{Total Time}	_{55.39s (± 0.49%)}	_{55.41s (± 0.36%)}	_~	_55.21s	_55.77s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,880	_1,226,880	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,745	_266,745	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,912,333k (±12.85%)}	_{3,032,987k (± 9.77%)}	_~	_2,427,649k	_3,154,399k	_{p=0.575 n=6}
_{Parse Time}	_{6.93s (± 2.07%)}	_{6.95s (± 1.56%)}	_~	_6.76s	_7.05s	_{p=0.936 n=6}
_{Bind Time}	_{2.15s (± 2.15%)}	_{2.16s (± 1.43%)}	_~	_2.11s	_2.20s	_{p=0.936 n=6}
_{Check Time}	_{42.69s (± 0.42%)}	_{42.76s (± 0.38%)}	_~	_42.43s	_42.88s	_{p=0.298 n=6}
_{Emit Time}	_{3.44s (± 2.06%)}	_{3.47s (± 3.06%)}	_~	_3.35s	_3.59s	_{p=0.748 n=6}
_{Total Time}	_{55.22s (± 0.57%)}	_{55.36s (± 0.36%)}	_~	_55.01s	_55.59s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,439	_262,439	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,628	_106,628	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,058k (± 0.01%)}	_{440,106k (± 0.02%)}	_~	_439,997k	_440,281k	_{p=0.521 n=6}
_{Parse Time}	_{2.88s (± 0.64%)}	_{2.88s (± 0.86%)}	_~	_2.85s	_2.92s	_{p=0.803 n=6}
_{Bind Time}	_1.10s	_1.10s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{15.73s (± 0.13%)}	_{15.77s (± 0.18%)}	_{+0.04s (+ 0.28%)}	_15.74s	_15.81s	_{p=0.019 n=6}
_{Emit Time}	_{1.30s (± 1.05%)}	_{1.29s (± 0.80%)}	_~	_1.28s	_1.30s	_{p=0.931 n=6}
_{Total Time}	_{21.00s (± 0.13%)}	_{21.05s (± 0.18%)}	_~	_21.00s	_21.09s	_{p=0.063 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,597k (± 0.02%)}	_{371,587k (± 0.02%)}	_~	_371,508k	_371,671k	_{p=0.810 n=6}
_{Parse Time}	_{2.92s (± 0.56%)}	_{2.88s (± 0.97%)}	_~	_2.85s	_2.93s	_{p=0.076 n=6}
_{Bind Time}	_{1.60s (± 1.00%)}	_{1.60s (± 1.84%)}	_~	_1.57s	_1.65s	_{p=0.460 n=6}
_{Check Time}	_{16.50s (± 0.42%)}	_{16.56s (± 0.56%)}	_~	_16.47s	_16.68s	_{p=0.336 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{21.01s (± 0.44%)}	_{21.05s (± 0.47%)}	_~	_20.95s	_21.14s	_{p=0.377 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,230,432	_3,230,432	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,112,113	_1,112,113	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,294,680k (± 0.01%)}	_{3,294,902k (± 0.01%)}	_~	_3,294,436k	_3,295,246k	_{p=0.298 n=6}
_{Parse Time}	_{14.19s (± 0.34%)}	_{14.14s (± 0.81%)}	_~	_14.03s	_14.34s	_{p=0.198 n=6}
_{Bind Time}	_{4.53s (± 0.48%)}	_{4.54s (± 0.40%)}	_~	_4.52s	_4.56s	_{p=0.511 n=6}
_{Check Time}	_{88.63s (± 1.97%)}	_{90.47s (± 3.03%)}	_~	_87.35s	_94.58s	_{p=0.520 n=6}
_{Emit Time}	_{27.54s (± 8.22%)}	_{26.16s (± 9.72%)}	_~	_22.91s	_28.99s	_{p=0.173 n=6}
_{Total Time}	_{134.90s (± 0.86%)}	_{135.31s (± 1.45%)}	_~	_132.73s	_137.84s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_291,562	_291,562	_~	_~	_~	_{p=1.000 n=6}
_Types	_118,971	_118,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{445,358k (± 0.02%)}	_{445,280k (± 0.03%)}	_~	_445,129k	_445,463k	_{p=0.230 n=6}
_{Parse Time}	_{5.13s (± 0.49%)}	_{5.12s (± 1.06%)}	_~	_5.05s	_5.20s	_{p=0.573 n=6}
_{Bind Time}	_{2.21s (± 0.92%)}	_{2.20s (± 0.73%)}	_~	_2.18s	_2.23s	_{p=0.446 n=6}
_{Check Time}	_{23.31s (± 0.52%)}	_{23.33s (± 0.62%)}	_~	_23.21s	_23.61s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.65s (± 0.45%)}	_{30.66s (± 0.38%)}	_~	_30.56s	_30.84s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,017	_555,017	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,115	_186,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{493,979k (± 0.02%)}	_{493,970k (± 0.03%)}	_~	_493,736k	_494,091k	_{p=0.936 n=6}
_{Parse Time}	_{3.41s (± 0.63%)}	_{3.40s (± 0.78%)}	_~	_3.38s	_3.45s	_{p=0.623 n=6}
_{Bind Time}	_{1.16s (± 0.94%)}	_{1.17s (± 0.94%)}	_~	_1.16s	_1.18s	_{p=0.227 n=6}
_{Check Time}	_{19.67s (± 1.20%)}	_{19.62s (± 1.30%)}	_~	_19.39s	_20.12s	_{p=0.423 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.25s (± 1.01%)}	_{24.19s (± 1.09%)}	_~	_23.93s	_24.69s	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-12-22T02:06:49Z

@DanielRosenwasser Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60830/merge:

Everything looks good!

Compute more precise syntactic truthy semantics for comma expressions

a4a7992

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 20, 2024

Andarist mentioned this pull request Dec 20, 2024

if-statements allow multiple arguments and don't check for constant conditions after the first argument #60822

Open

update baselines

170e0aa

Andarist force-pushed the comma-expressions-syntactic-truthy-semantics branch from 5ea795b to 170e0aa Compare December 20, 2024 23:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compute more precise syntactic truthy semantics for comma expressions #60830

Compute more precise syntactic truthy semantics for comma expressions #60830

Andarist commented Dec 20, 2024 •

edited

Loading

DanielRosenwasser commented Dec 22, 2024

typescript-bot commented Dec 22, 2024 •

edited

Loading

typescript-bot commented Dec 22, 2024

typescript-bot commented Dec 22, 2024

typescript-bot commented Dec 22, 2024

tsc

typescript-bot commented Dec 22, 2024

Compute more precise syntactic truthy semantics for comma expressions #60830

Are you sure you want to change the base?

Compute more precise syntactic truthy semantics for comma expressions #60830

Conversation

Andarist commented Dec 20, 2024 • edited Loading

DanielRosenwasser commented Dec 22, 2024

typescript-bot commented Dec 22, 2024 • edited Loading

typescript-bot commented Dec 22, 2024

typescript-bot commented Dec 22, 2024

typescript-bot commented Dec 22, 2024

tsc

typescript-bot commented Dec 22, 2024

Andarist commented Dec 20, 2024 •

edited

Loading

typescript-bot commented Dec 22, 2024 •

edited

Loading