-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan file support #205
Plan file support #205
Conversation
chhwang
commented
Jan 16, 2024
•
edited
Loading
edited
- Completely separate model definition from implementation
- Plan file details full implementation
- Models and plans are serialized into JSON
- Deeper integration with MSCCL++
- A few bug fixes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 86.95% 90.50% +3.54%
==========================================
Files 85 103 +18
Lines 5843 3958 -1885
==========================================
- Hits 5081 3582 -1499
+ Misses 762 376 -386 ☔ View full report in Codecov by Sentry. |
5e64787
to
473288c
Compare
94d33b1
to
9c26e9a
Compare
432d777
to
2a5a4a7
Compare
2a5a4a7
to
a5608fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Just have several questions. Will finish the review soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't review all files. Since most of op related code are similar, just reviewed some of them