-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch token count issue while streaming with customized models #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If llama, llava, phi, or some other models are used for streaming (with stream=True), the current design would crash after fetching the response. A warning is enough in this case, just like the non-streaming use cases.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3241 +/- ##
===========================================
- Coverage 33.24% 21.29% -11.95%
===========================================
Files 99 99
Lines 11016 11020 +4
Branches 2365 2537 +172
===========================================
- Hits 3662 2347 -1315
- Misses 7026 8507 +1481
+ Partials 328 166 -162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sonichi
reviewed
Jul 29, 2024
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:23 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
jackgerrits
had a problem deploying
to
openai1
September 25, 2024 14:56 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If llama, llava, phi, or some other models are used for streaming (with stream=True), the current design would crash after fetching the response.
A warning is enough in this case, just like the non-streaming use cases.
Why are these changes needed?
Related issue number
Checks