-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async nested chats #3289
Conversation
@heyitsaamir, thanks for the contribution! I know this is still a draft PR, but several reminders:
|
Yep. Working on tests. I am surprised there are no existing tests for nested chats. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3289 +/- ##
===========================================
- Coverage 32.90% 18.48% -14.42%
===========================================
Files 94 103 +9
Lines 10235 10932 +697
Branches 2193 2498 +305
===========================================
- Hits 3368 2021 -1347
- Misses 6580 8709 +2129
+ Partials 287 202 -85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closing in favor of #3309 |
In this PR:
use_async
flag toregister_nested_chats
function. This allows the nested chats to internally runa_initiate_chats
instead ofinitiate_chats
.Why are these changes needed?
We support nested chats and async initiate_chats. However, if a chat is started asynchronously, nested chats still currently run in-process.
Related issue number
Closes #3286
Checks