-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ImportFromModule
is unhashable issue
#3362
fix ImportFromModule
is unhashable issue
#3362
Conversation
This fix makes the conversion to string prior to the deduplication to avoid this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @zcipod for the PR! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix the type check error? Thanks.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3362 +/- ##
==========================================
- Coverage 32.90% 25.89% -7.02%
==========================================
Files 94 101 +7
Lines 10235 10752 +517
Branches 2193 2456 +263
==========================================
- Hits 3368 2784 -584
- Misses 6580 7673 +1093
- Partials 287 295 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sorry for late response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zcipod , could you please run pre-commit to fix the code format issue? Thanks. https://microsoft.github.io/autogen/docs/contributor-guide/pre-commit
Head branch was pushed to by a user without write access
Could you please have a review of this PR? Thanks! |
* ImportFromModule is unhashable This fix makes the conversion to string prior to the deduplication to avoid this issue * add type annotation for global_imports * meet code formatting check --------- Co-authored-by: zcipod <[email protected]> Co-authored-by: Li Jiang <[email protected]>
This fix makes the conversion to string prior to the deduplication to avoid this issue
Why are these changes needed?
When create user defined functions, an exception occurs because of the deduplication of ImportFromModule
This fix makes the conversion to string prior to the deduplication to avoid this issue
Related issue number
Closes #3361
Checks