-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Graph RAG] Init Commit with GraphRag interfaces #3388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @randombet for the PR. I've left some minor suggestions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3388 +/- ##
===========================================
- Coverage 32.90% 22.24% -10.67%
===========================================
Files 94 105 +11
Lines 10235 11095 +860
Branches 2193 2540 +347
===========================================
- Hits 3368 2468 -900
- Misses 6580 8383 +1803
+ Partials 287 244 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct that this PR creates the interfaces for GraphRAG but does not fully implement it? Will example notebooks and use cases be added to this PR?
The original plan is to first add interface and then add implementations. In this PR, only interface will be added. WDYT? @gagb |
Thank you @thinkall I trust your expertise on this PR! Is there a reason to merge this before adding an implementation? Also can we remove the changes in the notebook -- they seems to be unrelated :) But the changes in the notebook are also non consequential. |
@thinkall I updated the PR, pls review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @randombet , would you like to add a test for graph_rag? Thanks.
Thanks! When do you plan to release the next version with this capability? |
Why are these changes needed?
Graph RAG is a long-sought feature from the community, we plan to support this and integrate FalkorDB and MS GraphRAG.
Please refer to the design doc for more details.
https://docs.google.com/document/d/15uuNrJrxujX8biPCAZzAtmeMKOFB4SEMkVszcE9nzRo/edit
This is the first PR to set up the graph rag interfaces.
Related issue number
GraphRAG support #3119
Checks