Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use Qdrant's Query API #3428

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

Anush008
Copy link
Collaborator

Description

This PR updates the Qdrant integration to use the new Query API that supersedes the search API.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.40%. Comparing base (0d5163b) to head (e25559c).

Files with missing lines Patch % Lines
autogen/agentchat/contrib/vectordb/qdrant.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3428      +/-   ##
==========================================
+ Coverage   29.72%   30.40%   +0.67%     
==========================================
  Files         113      113              
  Lines       12308    12308              
  Branches     2607     2607              
==========================================
+ Hits         3659     3742      +83     
+ Misses       8321     8237      -84     
- Partials      328      329       +1     
Flag Coverage Δ
unittests 30.38% <0.00%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb gagb requested a review from thinkall August 27, 2024 06:39
@gagb gagb requested review from thinkall and removed request for thinkall September 9, 2024 05:38
@jackgerrits
Copy link
Member

@thinkall can you review?

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @Anush008 ! LGTM.

@thinkall thinkall enabled auto-merge September 26, 2024 06:37
@thinkall thinkall added this pull request to the merge queue Sep 26, 2024
Merged via the queue into microsoft:main with commit f958f17 Sep 26, 2024
35 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants