Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Bedrock client uses incorrect environment variables for authentication #4657

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

vaisakh-prod
Copy link

@vaisakh-prod vaisakh-prod commented Dec 11, 2024

Why are these changes needed?

The AWS Bedrock client uses AWS_ACCESS_KEY and AWS_SECRET_KEY as environment variables., the names of which has been updated. in ref: here these changes are to update the code base to keep in line with the same.

Related issue number

Closes #3500

Checks

… uses incorrect environment variables for authentication microsoft#3500
@vaisakh-prod
Copy link
Author

@vaisakh-prod please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekzhu ekzhu merged commit 837b2e0 into microsoft:0.2 Dec 12, 2024
35 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants