-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NavigationBar's title view constraints #1891
Merged
laminesm
merged 6 commits into
microsoft:main
from
laminesm:laminemale/fix-two-line-title-on-nav-bar
Sep 18, 2023
Merged
Fix NavigationBar's title view constraints #1891
laminesm
merged 6 commits into
microsoft:main
from
laminesm:laminemale/fix-two-line-title-on-nav-bar
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwilkes
approved these changes
Sep 11, 2023
huwilkes
reviewed
Sep 11, 2023
huwilkes
approved these changes
Sep 18, 2023
2 tasks
laminesm
added a commit
to laminesm/fluentui-apple
that referenced
this pull request
Sep 26, 2023
* Update titleView constraints to fit the nav bar * Rewrite the logic * Always update the title view contraints to fit * Rename titleview constraints function * Address comments * Silence constraints warning
2 tasks
laminesm
added a commit
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
There has been an issue where the two line title view would not fit in our navigation bar (#1883). It turns out that the constraints of the title view were not set to fit the navigation bar (which is how Apple handles the native title view).
Changes:
Binary change
Total increase: 1,512 bytes
Total decrease: -488 bytes
Full breakdown
Verification
Tested fix on pro, pro max, and iPad devices on the fluent demo app.
Visual Verification
Pull request checklist
This PR has considered: