Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing view cutoff in iPad when showing DrawerController #1893

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Sep 18, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

On iPad, there was a noticeable view cut off when using the UIPopupMenuController. Turns out this was happening because the contentView would cut into the arrow. Setting isLayoutMarginsRelativeArrangement to true fixes the view from getting cut off.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

Added additional test case scenarios for UIPopupMenuController, tested on both iPhone and iPad.

Visual Verification
Before After
image image
NA image
NA image
image image
NA image
NA image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@sophialee0416 sophialee0416 requested a review from a team as a code owner September 18, 2023 23:39
@sophialee0416 sophialee0416 merged commit 1766700 into microsoft:main Sep 19, 2023
6 checks passed
sophialee0416 added a commit that referenced this pull request Sep 19, 2023
sophialee0416 added a commit that referenced this pull request Sep 19, 2023
Fixing view cutoff in iPad when showing DrawerController (#1893)
@sophialee0416 sophialee0416 deleted the sople/popupFix branch October 11, 2023 01:01
@huwilkes huwilkes mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants