Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @floating-ui/dom #33458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+35 −27
Open

chore: bump @floating-ui/dom #33458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67b1699
chore: bump Floating UI
radium-v Oct 15, 2024
e887305
Merge branch 'master' into chore/bump-floating-ui
layershifter Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-positioning-f474a804-4972-4d68-b0dc-f1d699251a90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

Callout 5 screenshots
Image Name Diff(in Pixels) Image Type
Callout.Bottom Right Edge RTL.chromium.png 1593 Changed
Callout.Bottom auto edge.chromium.png 2309 Changed
Callout.Left top edge.chromium.png 1949 Changed
Callout.Bottom left edge.chromium.png 2309 Changed
Callout.Left center.chromium.png 2616 Changed
react-charting-AreaChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-AreaChart.Custom Accessibility.chromium.png 11 Changed
react-charting-HeatMapChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-HeatMapChart.Basic.chromium.png 376 Changed
react-charting-LineChart 2 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-LineChart.Events.chromium.png 2 Changed
react-charting-LineChart.Gaps.chromium.png 1 Changed

Copy link
Collaborator

@fabricteam fabricteam Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.badgeMask.chromium.png 3 Changed
Avatar Converged.Badge Mask RTL.chromium.png 7 Changed
Drawer 2 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.Full Overlay Dark Mode.chromium.png 2798 Changed
Drawer.Full Overlay High Contrast.chromium.png 5191 Changed

"type": "patch",
"comment": "chore: bump @floating-ui/dom",
"packageName": "@fluentui/react-positioning",
"email": "[email protected]",
"dependentChangeType": "none"
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"@dnd-kit/core": "^6.0.8",
"@dnd-kit/sortable": "^7.0.2",
"@dnd-kit/utilities": "^3.2.1",
"@floating-ui/dom": "1.2.0",
"@floating-ui/dom": "1.6.12",
"@fluentui/react-icons": "^2.0.245",
"@griffel/babel-preset": "1.5.8",
"@griffel/eslint-plugin": "^1.6.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-positioning/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@fluentui/scripts-api-extractor": "*"
},
"dependencies": {
"@floating-ui/dom": "^1.2.0",
"@floating-ui/dom": "^1.6.12",
"@floating-ui/devtools": "0.2.1",
"@fluentui/react-shared-contexts": "^9.21.2",
"@fluentui/react-theme": "^9.1.24",
Expand Down
10 changes: 5 additions & 5 deletions packages/react-components/react-positioning/src/middleware/matchTargetSize.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import type { MiddlewareArguments } from '@floating-ui/dom';
import type { MiddlewareState } from '@floating-ui/dom';
import { matchTargetSize, matchTargetSizeCssVar } from './matchTargetSize';

describe('matchTargetSize', () => {
Expand All @@ -21,7 +21,7 @@ describe('matchTargetSize', () => {
reference: { width: referenceWidth },
floating: { width: '1px' },
},
} as unknown as MiddlewareArguments;
} as unknown as MiddlewareState;

const result = await middlewareFn(middlewareArguments);

Expand Down Expand Up @@ -52,7 +52,7 @@ describe('matchTargetSize', () => {
reference: { width: referenceWidth },
floating: { width: '1px' },
},
} as unknown as MiddlewareArguments;
} as unknown as MiddlewareState;

const result = await middlewareFn(middlewareArguments);

Expand Down Expand Up @@ -82,7 +82,7 @@ describe('matchTargetSize', () => {
reference: { width: referenceWidth },
floating: { width: referenceWidth },
},
} as unknown as MiddlewareArguments;
} as unknown as MiddlewareState;

const result = await middlewareFn(middlewareArguments);

Expand All @@ -103,7 +103,7 @@ describe('matchTargetSize', () => {
reference: { width: referenceWidth },
floating: { width: '1px' },
},
} as unknown as MiddlewareArguments;
} as unknown as MiddlewareState;

const result = await middlewareFn(middlewareArguments);

Expand Down
4 changes: 2 additions & 2 deletions packages/react-components/react-positioning/src/utils/devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import type { MiddlewareArguments } from '@floating-ui/dom';
import type { MiddlewareState } from '@floating-ui/dom';
import type { PositioningOptions } from '../types';
import { isHTMLElement } from '@fluentui/react-utilities';
import { listScrollParents } from './listScrollParents';
import { fromFloatingUIPlacement } from './fromFloatingUIPlacement';

export const devtoolsCallback = (options: PositioningOptions) => (middlewareState: MiddlewareArguments) => {
export const devtoolsCallback = (options: PositioningOptions) => (middlewareState: MiddlewareState) => {
const {
elements: { floating, reference },
} = middlewareState;
Expand Down
4 changes: 2 additions & 2 deletions packages/react-components/react-positioning/src/utils/getFloatingUIOffset.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { MiddlewareArguments } from '@floating-ui/dom';
import { MiddlewareState } from '@floating-ui/dom';
import { OffsetFunction } from '../types';
import { FloatingUIOffsetFunction, getFloatingUIOffset } from './getFloatingUIOffset';

describe('getFloatingUIOffset', () => {
const testMiddlewareArgs: MiddlewareArguments = {
const testMiddlewareArgs: MiddlewareState = {
elements: {
reference: document.createElement('div'),
floating: document.createElement('div'),
Expand Down
4 changes: 2 additions & 2 deletions packages/react-components/react-positioning/src/utils/getFloatingUIOffset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { Offset } from '../types';
import type { MiddlewareArguments } from '@floating-ui/dom';
import type { MiddlewareState } from '@floating-ui/dom';
import { fromFloatingUIPlacement } from './fromFloatingUIPlacement';
/**
* Type taken from Floating UI since they are not exported
Expand Down Expand Up @@ -30,7 +30,7 @@ export type FloatingUIOffsetValue =
/**
* Type taken from Floating UI since they are not exported
*/
export type FloatingUIOffsetFunction = (args: MiddlewareArguments) => FloatingUIOffsetValue;
export type FloatingUIOffsetFunction = (args: MiddlewareState) => FloatingUIOffsetValue;

/**
* Shim to transform offset values from this library to Floating UI
Expand Down
29 changes: 15 additions & 14 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,24 +1877,25 @@
resolved "https://registry.yarnpkg.com/@fal-works/esbuild-plugin-global-externals/-/esbuild-plugin-global-externals-2.1.2.tgz#c05ed35ad82df8e6ac616c68b92c2282bd083ba4"
integrity sha512-cEee/Z+I12mZcFJshKcCqC8tuX5hG3s+d+9nZ3LabqKF1vKdF41B92pJVCBggjAGORAeOzyyDDKrZwIkLffeOQ==

"@floating-ui/core@^1.2.0":
version "1.6.6"
resolved "https://registry.yarnpkg.com/@floating-ui/core/-/core-1.6.6.tgz#f6edf703c8acb73e3802cf558c88ddb7cddc4f67"
integrity sha512-Vkvsw6EcpMHjvZZdMkSY+djMGFbt7CRssW99Ne8tar2WLnZ/l3dbxeTShbLQj+/s35h+Qb4cmnob+EzwtjrXGQ==
"@floating-ui/core@^1.6.0":
version "1.6.8"
resolved "https://registry.yarnpkg.com/@floating-ui/core/-/core-1.6.8.tgz#aa43561be075815879305965020f492cdb43da12"
integrity sha512-7XJ9cPU+yI2QeLS+FCSlqNFZJq8arvswefkZrYI1yQBbftw6FyrZOxYSh+9S7z7TpeWlRt9zJ5IhM1WIL334jA==
dependencies:
"@floating-ui/utils" "^0.2.6"
"@floating-ui/utils" "^0.2.8"

"@floating-ui/[email protected]":
version "0.2.1"
resolved "https://registry.yarnpkg.com/@floating-ui/devtools/-/devtools-0.2.1.tgz#3e8023e09ede273a7aa426e7911f3dac630024c5"
integrity sha512-8PHJLbD6VhBh+LJ1uty/Bz30qs02NXCE5u8WpOhSewlYXUWl03GNXknr9AS2yaAWJEQaY27x7eByJs44gODBcw==

"@floating-ui/dom@1.2.0", "@floating-ui/dom@^1.0.0", "@floating-ui/dom@^1.2.0":
version "1.2.0"
resolved "https://registry.yarnpkg.com/@floating-ui/dom/-/dom-1.2.0.tgz#a60212069cc58961c478037c30eba4b191c75316"
integrity sha512-QXzg57o1cjLz3cGETzKXjI3kx1xyS49DW9l7kV2jw2c8Yftd434t2hllX0sVGn2Q8MtcW/4pNm8bfE1/4n6mng==
"@floating-ui/dom@1.6.12", "@floating-ui/dom@^1.0.0", "@floating-ui/dom@^1.6.12":
version "1.6.12"
resolved "https://registry.yarnpkg.com/@floating-ui/dom/-/dom-1.6.12.tgz#6333dcb5a8ead3b2bf82f33d6bc410e95f54e556"
integrity sha512-NP83c0HjokcGVEMeoStg317VD9W7eDlGK7457dMBANbKA6GJZdc7rjujdgqzTaz93jkGgc5P/jeWbaCHnMNc+w==
dependencies:
"@floating-ui/core" "^1.2.0"
"@floating-ui/core" "^1.6.0"
"@floating-ui/utils" "^0.2.8"

"@floating-ui/react-dom@^2.0.0":
version "2.1.1"
Expand All @@ -1903,10 +1904,10 @@
dependencies:
"@floating-ui/dom" "^1.0.0"

"@floating-ui/utils@^0.2.6":
version "0.2.6"
resolved "https://registry.yarnpkg.com/@floating-ui/utils/-/utils-0.2.6.tgz#1898a31c7e17a50384147a02a4e6264b1b1a0291"
integrity sha512-0KI3zGxIUs1KDR/pjQPdJH4Z8nGBm0yJ5WRoRfdw1Kzeh45jkIfA0rmD0kBF6fKHH+xaH7g8y4jIXyAV5MGK3g==
"@floating-ui/utils@^0.2.8":
version "0.2.8"
resolved "https://registry.yarnpkg.com/@floating-ui/utils/-/utils-0.2.8.tgz#21a907684723bbbaa5f0974cf7730bd797eb8e62"
integrity sha512-kym7SodPp8/wloecOpcmSnWJsK7M0E5Wg8UcFA+uO4B9s5d0ywXOEro/8HM9x0rW+TljRzul/14UYz3TleT3ig==

"@fluentui/dom-utilities@^1.1.1":
version "1.1.1"
Expand Down
Loading