-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Collapse): streamline atom functions #33463
Draft
robertpenner
wants to merge
4
commits into
microsoft:master
Choose a base branch
from
robertpenner:refactor/collapse-atoms
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor(Collapse): streamline atom functions #33463
robertpenner
wants to merge
4
commits into
microsoft:master
from
robertpenner:refactor/collapse-atoms
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
robertpenner
force-pushed
the
refactor/collapse-atoms
branch
from
December 12, 2024 22:49
0aea9d7
to
3608e82
Compare
fabricteam
reviewed
Dec 12, 2024
change/@fluentui-react-motion-components-preview-67537ce1-b461-4bec-bbcb-61d9202e6632.json
Show resolved
Hide resolved
robertpenner
force-pushed
the
refactor/collapse-atoms
branch
3 times, most recently
from
December 16, 2024 18:31
cd9ec1a
to
d84a7fa
Compare
- put in a new atoms folder that is shared amongst motion components - rename from opacityAtom to fadeAtom
robertpenner
force-pushed
the
refactor/collapse-atoms
branch
2 times, most recently
from
December 18, 2024 17:53
65cf213
to
53ccc82
Compare
robertpenner
force-pushed
the
refactor/collapse-atoms
branch
from
December 18, 2024 18:17
53ccc82
to
fca343d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)