chore: upgrade typescript to 5.5.2 #33498
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
fabricteam
reviewed
Dec 20, 2024
| @@ -69,8 +69,8 @@ | |||
| "@griffel/webpack-loader": "2.2.10", | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.chromium.png | 8 | Changed |
| Avatar Converged.Badge Mask RTL.chromium.png | 4 | Changed |
🕵 FluentUIV0 No visual regressions between this PR and main |
mainframev
commented
Dec 20, 2024
| @@ -85,7 +91,9 @@ export function classNamesFunction<TStyleProps extends {}, TStyleSet extends ISt | |||
| typeof styleFunctionOrObject === 'function' && | |||
| (styleFunctionOrObject as StyleFunction<TStyleProps, TStyleSet>).__noStyleOverride__ | |||
| ) { | |||
| return styleFunctionOrObject(styleProps) as IProcessedStyleSet<TStyleSet>; | |||
| return (styleFunctionOrObject as IStyleFunction<TStyleProps, TStyleSet>)( | |||
There was a problem hiding this comment.
had to add additional casting, throwing after upgrade with this TS2349:
| state.components?.[slotName] === undefined || typeof state.components[slotName] === 'string' | ||
| ? asProp || state.components?.[slotName] || 'div' | ||
| : state.components[slotName] | ||
| ) as React.ElementType<R[K]>; | ||
| : state.components[slotName]; |
There was a problem hiding this comment.
after upgrade throws TS2590: Expression produces a union type that is too complex to represent
| @@ -3,7 +3,7 @@ | |||
| "compilerOptions": { | |||
| "isolatedModules": false, | |||
| "types": ["node", "cypress", "cypress-real-events"], | |||
| "typeRoots": ["../../../../node_modules", "../../../../node_modules/@types"], | |||
| "typeRoots": ["${configDir}/node_modules", "${configDir}/node_modules/@types"], | |||
There was a problem hiding this comment.
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
0adbb48 to
296644f
Compare
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
29cadea to
ea576b0
Compare
mainframev
commented
Dec 20, 2024
packages/codemods/package.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "tslib": "^2.1.0", | |||
| "react": "17.0.2", | |||
| "ts-morph": "^10.0.1", | |||
| "typescript": "5.3.3", | |||
There was a problem hiding this comment.
had to lock ts to 5.3.3 for this package, as ts-morph has issue with 5.4: dsherret/ts-morph#1513. Fixed in v22, current is 10 😢
chore(utilities): update api.md chore(react-utilities): update api.md chore(style-utilities): update api.md
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
ea576b0 to
3ee9cbd
Compare
fabricteam
reviewed
Dec 20, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Bottom Left Edge RTL.chromium.png | 2178 | Changed |
| Callout.Beak 25.chromium.png | 2186 | Changed |
| Callout.Root.chromium.png | 2309 | Changed |
react-charting-VerticalBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-VerticalBarChart.Basic - Secondary Y Axis.chromium.png | 4 | Changed |
|
Pull request demo site: URL |
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
3ee9cbd to
83e4110
Compare
📊 Bundle size report
Unchanged fixtures
|
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
83e4110 to
0e865c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates ts to 5.5.2, also bumped api-extractor and api-extractor model to the latest.
JSDoc import tag changes will be addded as a follow-up.
Release notes
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-4.html
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-5.html
Previous Behavior
New Behavior
Related Issue(s)