Plotly examples bug fixes #33507
Open
Plotly examples bug fixes #33507
+80
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Dec 23, 2024
change/@fluentui-react-charting-93685ac9-5787-4456-9159-5670992837e0.json
Show resolved
Hide resolved
AtishayMsft
reviewed
Dec 23, 2024
packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
Show resolved
Hide resolved
AtishayMsft
reviewed
Dec 23, 2024
packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Dec 23, 2024
| x: updateXValues(dataPoint.x), | ||
| })); | ||
| const chartProps = { | ||
| ...transformPlotlyJsonToScatterChartProps({ data: updatedData, layout }, isAreaChart, colorMap, isDarkTheme), |
There was a problem hiding this comment.
it can be handled in chartProps only, right? Also I missed componentRef={chartRef}, that also will add. Or what do you suggest, should I remove renderChart and duplicate Areachart and linechart render statements ?
There was a problem hiding this comment.
add line specific legend props to chartProps if it is line. This check will anyways go away in couple of days.
AtishayMsft
reviewed
Dec 23, 2024
|
|
||
| export const updateXValues = (xValues: any[]): any[] => { | ||
| const presentYear = new Date().getFullYear(); | ||
| const dates = xValues.map(monthValue => { |
AtishayMsft
reviewed
Dec 23, 2024
| export const isMonthArray = (array: any[]): boolean => { | ||
| if (array && array.length > 0) { | ||
| const presentYear = new Date().getFullYear(); | ||
| return array.every(monthValue => { |
AtishayMsft
reviewed
Dec 23, 2024
| @@ -272,7 +304,6 @@ export const transformPlotlyJsonToScatterChartProps = ( | |||
| isDarkTheme?: boolean, | |||
| ): ILineChartProps | IAreaChartProps => { | |||
| const { data, layout } = jsonObj; | |||
|
|
|||
| const chartData: ILineChartPoints[] = data.map((series: any, index: number) => { | |||
| const xValues = series.x; | |||
There was a problem hiding this comment.
revert removing empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Following bugs are fixed:
Functionality added:
To support month names as x-axis labels in line and area chart.
Related Issue(s)