Skip to content

Commit

Permalink
Finish website and nits
Browse files Browse the repository at this point in the history
  • Loading branch information
hamdaankhalidmsft committed Dec 17, 2024
1 parent 4e327b4 commit f3ba0c1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion libs/server/Storage/Functions/MainStore/RMWMethods.cs
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ private bool InPlaceUpdaterWorker(ref SpanByte key, ref RawStringInput input, re
// Copy value to output for the GET part of the command.
CopyRespTo(ref value, ref output, etagIgnoredOffset, etagIgnoredEnd);
}
// HK TODO: Should this be updating etag?
return true;
case RespCommand.SETWITHETAG:
// SETWITHETAG WILL OVERRIDE the existing value, unless sent with RETAIN ETAG and already has etag
Expand Down
6 changes: 0 additions & 6 deletions test/Garnet.test/RespCustomCommandTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ public override bool Execute<TGarnetApi>(TGarnetApi garnetApi, ref CustomProcedu
}
}

// one txn that works with etag data in multiple ways
public class RandomSubstituteOrExpandValForKeyTxn : CustomTransactionProcedure
{
public override bool Prepare<TGarnetReadApi>(TGarnetReadApi api, ref CustomProcedureInput procInput)
Expand Down Expand Up @@ -222,11 +221,6 @@ public override unsafe void Main<TGarnetApi>(TGarnetApi garnetApi, ref CustomPro
}
}

// HK TODO:
// one custom proc that reads and works with etag data
// assert that all reads inside of a txn or custom for a previously etag are hiding etag
// assert that any writes on the etag set data modified the etag on it

[TestFixture]
public class RespCustomCommandTests
{
Expand Down
2 changes: 1 addition & 1 deletion website/docs/commands/raw-string.md
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ Set **key** to hold the string value. If key already holds a value, it is overwr
* NX -- Only set the key if it does not already exist.
* XX -- Only set the key if it already exists.
* KEEPTTL -- Retain the time to live associated with the key.
* RETAINETAG -- Update the Etag associated with the previous key-value pair, while setting the new value for the key. If no etag existed on the previous key-value pair this will create the new key-value pair without any etag as well.
* RETAINETAG -- Update the Etag associated with the previous key-value pair, while setting the new value for the key. If no etag existed on the previous key-value pair this will create the new key-value pair without any etag as well. This is a Garnet specific command, you can read more about ETag support [here](../commands/garnet-specific-commands#native-etag-support)

#### Resp Reply

Expand Down

0 comments on commit f3ba0c1

Please sign in to comment.