refactor ORT-Extension for the coming GroupQueryAttention work #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenbingl
approved these changes
Mar 20, 2024
| } | ||
|
|
||
| template <typename T> | ||
| T ParseEnvironmentVariableWithDefault(const std::string& name, const T& default_value) { |
There was a problem hiding this comment.
where are these functions used?
There was a problem hiding this comment.
It will be used in the coming GroupQueryAttention code
wenbingl
reviewed
Mar 20, 2024
There was a problem hiding this comment.
any other file name? something ..._abi_wrapper.h
There was a problem hiding this comment.
My intention is to separate the ORT dependencies into 2 files: one contains custom op stuff only and the other doesn't. Let me merge this PR in first and then we can discuss the naming things later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ORT-Extension for the coming GroupQueryAttention work (#654).
Main changes: