Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support GroupQueryAttention #676

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

support GroupQueryAttention #676

wants to merge 5 commits into from

Conversation

jslhcl
Copy link
Contributor

@jslhcl jslhcl commented Mar 22, 2024

support GroupQueryAttention

@jslhcl jslhcl requested a review from a team as a code owner March 22, 2024 21:39
atol=atol,
equal_nan=True,
),
)

class TestCudaOps(unittest.TestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future (or potentially even in this PR), we can separate our Python tests for CUDA by different ops (like we do for cpu tests). Otherwise, in the long term this file will get too long (GitHub is already not showing its preview by default on this PR because of file size).

nit: regardless, we should probably rename this file as it is already under test/cuda, so test_cudaops.py is redundant.

Copy link
Contributor

@sayanshaw24 sayanshaw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a C++ unit test for GroupQueryAttention as well under test/shared_test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants