Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom ops Rotary #738

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add custom ops Rotary #738

wants to merge 14 commits into from

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Jun 6, 2024

No description provided.

@xadupre xadupre marked this pull request as ready for review June 6, 2024 14:12
@xadupre xadupre requested a review from a team as a code owner June 6, 2024 14:12
wenbingl
wenbingl previously approved these changes Jun 6, 2024
View reviewed changes
wenbingl
wenbingl previously approved these changes Jun 12, 2024
View reviewed changes
operators/cuda/rotary_impl.cu Show resolved Hide resolved
@xadupre xadupre self-assigned this Jun 21, 2024
wschin
wschin reviewed Jun 27, 2024
View reviewed changes
operators/cuda/rotary.h Outdated Show resolved Hide resolved
wschin
wschin reviewed Jun 27, 2024
View reviewed changes
operators/cuda/rotary.h Outdated Show resolved Hide resolved
wschin
wschin reviewed Jun 27, 2024
View reviewed changes
operators/cuda/rotary.h Outdated Show resolved Hide resolved
wschin
wschin reviewed Jun 27, 2024
View reviewed changes
operators/cuda/rotary.h Outdated Show resolved Hide resolved
wschin
wschin reviewed Jun 27, 2024
View reviewed changes
operators/cuda/rotary.h Outdated Show resolved Hide resolved
wschin
wschin requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments fall into two categories. For documentation, they are must-to-have. The rest are nit and optional. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wschin wschin wschin requested changes

@wenbingl wenbingl wenbingl left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@xadupre xadupre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xadupre @wschin @wenbingl