Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation error in GenAI #864

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Fix compilation error in GenAI #864

merged 3 commits into from
Dec 23, 2024

Conversation

skyline75489
Copy link
Collaborator

  • Fix compilation error due to min/max on Win32
  • Fix warning C5038: data member 'OrtxTokenizerBlob::raw_model_blob_len' will be initialized after data member 'OrtxTokenizerBlob::reserved_blob_1'

@skyline75489 skyline75489 marked this pull request as ready for review December 20, 2024 08:03
@skyline75489 skyline75489 requested a review from a team as a code owner December 20, 2024 08:03
@skyline75489 skyline75489 merged commit 4e10ee0 into main Dec 23, 2024
46 checks passed
@skyline75489 skyline75489 deleted the jialli/nominmax branch December 23, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenbingl wenbingl wenbingl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyline75489 @wenbingl